[$1000] The transition of opening a new workspace at the creation doesn't match to other pages reported by @Puneet-here

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > workspaces
2. Create a workspace
3. Check the transition

Expected Result:

The transition should match with other pages when we navigate from one page to another

Actual Result:

The previous page disappear and new page opens

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.21-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666951689786119

screen-recording-2022-10-28-at-32440-pm_lsU5MZg2.mov

View all open jobs on GitHub

Recording.804.mp4

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[michaelhaxhiu]

Hey @kevinksullivan, just dropping a note as a reminder to keep the pressure on to find a contributor and get this one closed out :)

Is this one external or internal? Let's label it accordingly and decide if it belongs in upwork or with an internal engineer. Either way, gonna add the engineering label so we can move it forward in terms of the process. Let me know if I can help!

[kevinksullivan]

Oh sorry @michaelhaxhiu , thanks for the reminder! Hm, this seems ever so slightly off so I could see a case for fixing. Posting to upwork for external, and hired @Puneet-here for reporting.

https://www.upwork.com/jobs/~018725fa3aa6f93d59

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @srikarparsi (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tungmt]

PROPOSAL:

Cause: The previous page disappear and new page opens because before navigate to new page the modal of previous page has been dismissed by Navigation.dismissModal();

Proposal: Remove the line Navigation.dismissModal(); it look like work normal on model. For the web with current source when we close the new page (new workspace that just created) it go to /settings . When we remove line Navigation.dismissModal(); it go to /settings/workspaces. Which one should be correct path when we close a workspace setting?

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[eVoloshchak]

@tungmt
You are right, this inconsistency is caused by this
Navigation.dismissModal()
However we can't remove it, it was added to fix an issue with transitions to existing workspaces from OldDot

Navigation.dismissModal(); // Dismiss /transition route for OldDot to NewDot transitions

So we have to either find a way to fix this without removing Navigation.dismissModal() or to find a way to resolve #10949 without using Navigation.dismissModal()

[melvin-bot]

@eVoloshchak, @youssef-lr, @kevinksullivan, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

Wasn't able to find this task in OldDot, asking in slack

[eVoloshchak]

Got a response and was able to test, @Puneet-here's proposal looks good!

🎀👀🎀 C+ reviewed!
cc: @kevinksullivan

[srikarparsi]

this looks good to me as well. Assigning you to the issue @Puneet-here.

[melvin-bot]

📣 @Puneet-here You have been assigned to this job by @srikarparsi!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Puneet-here]

@eVoloshchak the PR is ready for review.

[eVoloshchak]

Not overdue, PR was merged recently

[srikarparsi]

^

[melvin-bot]

@eVoloshchak, @kevinksullivan, @srikarparsi, @Puneet-here Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

Not overdue, PR has been deployed to production 5 days ago

[kevinksullivan]

Hm looks like this one just missed the notification to label properly. Waiting out the 7 day period still.

[JmillsExpensify]

Can you add [HOLD awaiting payment [Date]] on this issue? Just came across it trying to clear out bugs that need more help.

[Puneet-here]

It's ready for payment. It was deployed to production 8 days ago.

[JmillsExpensify]

Even better. Let's issue payment and close this out!

[kevinksullivan]

Paid @eVoloshchak for the C+ review and @Puneet-here for reporting + fixing.

[Puneet-here]

@kevinksullivan, I think it's also eligible for 50% bonus because the PR was merged within 3 business days ( there was saturday and sunday in the middle )

[Puneet-here]

bump @kevinksullivan

[kevinksullivan]

Created a new job to pay out bonus

https://www.upwork.com/jobs/~0165757f92835a450f

@Puneet-here @eVoloshchak let me know once you've accepted. Thanks

[eVoloshchak]

@Puneet-here @eVoloshchak let me know once you've accepted. Thanks

Accepted, thanks!

[Puneet-here]

Accepted, thanks!