[HOLD for payment 2022-11-22] [$500] mWeb - Request Money- Missing cursor when requesting/split the money

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing #10147

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Click FAB > Request Money
4. Enter an amount
5. Move cursor to the middle of the amount
   5.1. Enter a Digit
   5.2. Delete a digit
   5.3. Paste a couple of digits
   5.4. Cut a couple of digits

Expected Result:

Cursor should be present when requesting/split the money

Actual Result:

Missing cursor when requesting/split the money

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web (Android)

Version Number: 1.1.94.4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5710804_10147_Mweb.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

internal
external

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[AndrewGable]

This is a regression from #6154 - I believe @eVoloshchak should fix this.

[rushatgabhane]

@AndrewGable not really. This issue was present before the PR

I looked into solving it during 6154 PR, and i believe a fix for it is out of scope of the PR

[trjExpensify]

I'm also a bit confused by the steps in the OP versus the video. Something isn't clear, because I can see the cursor in the video? 😕

I also can't seem to reproduce it, if that's the problem as stated.

RPReplay_Final1661934698.MP4

[rushatgabhane]

@trjExpensify I think this is a mWeb - Android only issue

[trjExpensify]

Oh, I see. @kavimuru can you confirm that, please?

[adelekennedy]

my first checklist!

[rushatgabhane]

The PR that introduced the bug has been identified

I believe the cursor always went away after pressing the IOU numpad. This bug was always present, and not a regression

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.27-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix missing cursor on numpad #12498

If no regressions arise, payment will be issued on 2022-11-22. 🎊

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[thienlnam]

I added a link to the potential offending PR but it's from way back - #10147

cc @adelekennedy Are you able to take care of the other items on the checklist please? This looks ready to pay out as well #10693 (comment)

[rushatgabhane]

@thienlnam the issue existed before #10147, this bug was always present

[adelekennedy]

Hired!

[aimane-chnaif]

@thienlnam agreed timeline bonus (#12498 (comment))

[thienlnam]

Yeah, this PR should still be eligible for the 50% bonus - my bad should have clarified in this issue. Going to reopen so that can get taken care of

[aimane-chnaif]

@adelekennedy I see you made 2 offers and closed old one after pay out.
I think you can use the new one hired last Friday for bonus.

[melvin-bot]

@rushatgabhane, @thienlnam, @adelekennedy, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[thienlnam]

cc @adelekennedy for adding the bonus payment

[adelekennedy]

Bonuses paid out!