[HOLD for payment 2022-12-20] [$2000] mweb - Copy & Paste - Copy & Pasting text form code editor is not consistent

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account
3. Proceed to any chat
4. Copy text from a code editor and paste it in chat box (Observe the text format)
5. "Copy to clipboard" the text that was just sent and resend it in chat (Observe the code format)

Expected Result:

The user expects both text formats to be exactly like the one that was copied from the text editor.

Actual Result:

The two texts differ in format

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.88.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5676857_Text_from_code_editor_is_not_consistent.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[amyevans]

Reproducible on mobile web. Good external issue.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

Upwork Job

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @pecanoro (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[DharmeshCodeBase]

Yes i can do this as per your requirement and complete job

[pecanoro]

@MitchExpensify Let's double the price

[ahmdshrif]

I don't think this is an issue.

what happens exactly is the screen width is smaller than the line length.
so the code moved to the next line and that's correct behavior for normal text.

but if the user marks it as a code block by using ``` it will add a scroll block and the long line will not move to the next line.

Whatsapp has the same behavior:

our behavior when add code block :-

cc: @parasharrajat , @pecanoro

[parasharrajat]

@ahmdshrif Did you tested it on Mweb safari?

[JmillsExpensify]

We have one more day to approve/merge the PR and qualify for the 50% bonus! Looks like we have some initial comments from @parasharrajat in the PR.

[MitchExpensify]

Hired @b1tjoy for eventual Upwork payment!

[parasharrajat]

PR is ready for final review and merge.

[MitchExpensify]

I'm heading ooo so reassigning the bug label for a new CM!

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix copy and paste text inconsistent on mWeb #13396

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat / @pecanoro] The PR that introduced the bug has been identified. Link to the PR: Add support for the paste and match style command #9880
• [@parasharrajat / @pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not a regression per [HOLD for payment 2022-12-20] [$2000] mweb - Copy & Paste - Copy & Pasting text form code editor is not consistent #10262 (comment)
• [@parasharrajat / @pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not a regression per [HOLD for payment 2022-12-20] [$2000] mweb - Copy & Paste - Copy & Pasting text form code editor is not consistent #10262 (comment)
• [@miljakljajic] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[miljakljajic]

@b1tjoy , paid you in Upwork!

@parasharrajat - still waiting on you to approve the offer, then I can pay you!

[parasharrajat]

@miljakljajic Done.

[miljakljajic]

Paid!

[parasharrajat]

This might be eligible for Merged PR within 3 business days of assignment - 50% bonus

[miljakljajic]

Ah, you're right! @b1tjoy was assigned and the PR was reviewed and merged between Dec 6 and Dec 8. Paying your 50% bonus now. So sorry for missing that!

[miljakljajic]

Paid to both of you.

[pecanoro]

@parasharrajat Would you say this bug was a regression of implementing this #9880? It was a new feature so I don't think it's actually a regression. Also, I don't think we need to update the PR reviewer list.

@miljakljajic Did you update the regression tests to catch this bug in the future? Though the bug was caught by Applause, so maybe we have a test already for this.

[parasharrajat]

Yeah so we can say that I missed it testing on HTTPS connection. Because the dev server runs on http so it got missed in testing. I won't call it regression either. If we had caught it then it would have been fixed there.

[pecanoro]

@miljakljajic Feel free to close this issue when you confirm that actually the regression tests have been updated to cover this! (if necessary).

[JmillsExpensify]

@miljakljajic I'd also link the regression test request to this issue as well. Easier to keep track of everything.

[miljakljajic]

Thank you guys! There's an existing test for this (which makes sense given that Applause picked it up, as @pecanoro says):

https://expensify.testrail.io/index.php?/cases/view/1971016&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229062