Messages are being lost and fail to send

[Julesssss]

Problem

CC @cead22 @Expensify/mobile-deployers

Messages are disappearing and not being sent in NewDot. This is extremely annoying and is wasting all of our time. We need to figure out which issue introduced the regression, or locate the bug and fix it.

---

Action Performed:

It's not consistently reproducible, but these are the rough steps we have been following:

1. In NewDot (staging.new.expensify.com) Switch to a different chat
2. Type a message and hit enter
3. Sometimes the message disappears instead of sending.

Expected Result:

The message should send.

Actual Result:

The message is lost, no draft is kept, and no notification is received by the other user.

Workaround:

It works most of the time, but occasionally is being triggered. No known workaround exists yet.

Platform:

Where is this issue occurring?

So far, we have only been able to reproduce on web.

• Web
•  iOS (unknown)
•  Android (unknown)
•  Desktop App (unknown)
•  Mobile Web (unknown)

Version Number: v1.1.85-3
Reproducible in staging?: Yes
Reproducible in production?: Unknown
Email or phone of affected tester (no customers): any user
Logs: https://stackoverflow.com/c/expensify/questions/4856 N/A
Notes/Photos/Videos: Any additional supporting documentation N/A, everytime I record, I have been unable to reproduce
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658243988953749

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[AndrewGable]

web.min.js:1 Uncaught Error: Invalid undefined key provided in Onyx update. Onyx key must be of type string.
    at web.min.js:1:11206
    at Function.kt (each.js:14:7)
    at Object.$ [as update] (web.min.js:1:10986)
    at _l (API.js:23:14)
    at Qm (Report.js:1011:5)
    at Report.js:1040:5
    at n.value (ReportScreen.js:148:9)
    at n.value (ReportActionCompose.js:465:20)
    at n.value (ReportActionCompose.js:408:18)
    at r.forwardRef.ve.onKeyDown (index.js:278:7)
(anonymous) @ web.min.js:1
kt @ each.js:14
$ @ web.min.js:1
_l @ API.js:23
Qm @ Report.js:1011
(anonymous) @ Report.js:1040
value @ ReportScreen.js:148
value @ ReportActionCompose.js:465
value @ ReportActionCompose.js:408
r.forwardRef.ve.onKeyDown @ index.js:278
qe @ react-dom.production.min.js:52
Xe @ react-dom.production.min.js:52
(anonymous) @ react-dom.production.min.js:53
Er @ react-dom.production.min.js:100
Or @ react-dom.production.min.js:101
(anonymous) @ react-dom.production.min.js:113
Ie @ react-dom.production.min.js:292
(anonymous) @ react-dom.production.min.js:50
Mr @ react-dom.production.min.js:105
Qt @ react-dom.production.min.js:75
Zt @ react-dom.production.min.js:74
t.unstable_runWithPriority @ scheduler.production.min.js:18
qo @ react-dom.production.min.js:122
Re @ react-dom.production.min.js:292
Yt @ react-dom.production.min.js:73

[Julesssss]

Thanks, that's great. Sounds like there's an issue with the Onyx update occuring in the AddComment API. CC @marcaaron

Update: Neither the linked code above, nor the Web-E API hasn't been modified in a while...

[marcaaron]

Setting a key of undefined in Onyx throws an error? Hmm well that would certainly break things... maybe it should log instead 👀

[mvtglobally]

@Julesssss @marcaaron Our team noticed somewhat similar issue, but its not consistently repro. Should we log a new issue or this is same root cause?

In the process of sending a message, previous messages are temporarily not displayed.

mweb.1907.mp4

[marcaaron]

It's this here:

App/src/libs/actions/Report.js

Line 954 in 258c268

key: ONYXKEYS.MY_PERSONAL_DETAILS,

[marcaaron]

The ONYXKEYS.MY_PERSONAL_DETAILS was removed here -> #9560

And this was hard to reproduce because you need to wait 5 minutes so the timezone updating logic runs.

[mountiny]

That one key slipped out review 😬

this is the related PR #9560

[luacmartins]

Issue #10000, such a milestone 😄

[marcaaron]

In the process of sending a message, previous messages are temporarily not displayed.

@mvtglobally that looks like something else.

[mvtglobally]

We retested and it seem to be no longer repro

Recording.1222.mp4