Skip to content

Commit

Permalink
Merge pull request #15583 from Expensify/chirag-remove-shouldKeyRepor…
Browse files Browse the repository at this point in the history
…tActionsByID

Removing shouldKeyReportActionsByID
  • Loading branch information
techievivek authored Mar 28, 2023
2 parents d3b380d + 9a9e682 commit fc65409
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions src/libs/actions/IOU.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ function requestMoney(report, amount, currency, recipientEmail, participant, com
transactionID: optimisticReportAction.originalMessage.IOUTransactionID,
reportActionID: optimisticReportAction.reportActionID,
createdReportActionID: isNewChat ? optimisticCreatedAction.reportActionID : 0,
shouldKeyReportActionsByID: true,
}, {optimisticData, successData, failureData});
Navigation.navigate(ROUTES.getReportRoute(chatReport.reportID));
}
Expand Down Expand Up @@ -501,7 +500,6 @@ function splitBill(participants, currentUserLogin, amount, comment, currency, lo
transactionID: groupData.transactionID,
reportActionID: groupData.reportActionID,
createdReportActionID: groupData.createdReportActionID,
shouldKeyReportActionsByID: true,
}, onyxData);

Navigation.dismissModal();
Expand All @@ -527,7 +525,6 @@ function splitBillAndOpenReport(participants, currentUserLogin, amount, comment,
transactionID: groupData.transactionID,
reportActionID: groupData.reportActionID,
createdReportActionID: groupData.createdReportActionID,
shouldKeyReportActionsByID: true,
}, onyxData);

Navigation.navigate(ROUTES.getReportRoute(groupData.chatReportID));
Expand Down
6 changes: 0 additions & 6 deletions src/libs/actions/Report.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ function addActions(reportID, text = '', file) {
commentReportActionID: file && reportCommentAction ? reportCommentAction.reportActionID : null,
reportComment: reportCommentText,
file,
shouldKeyReportActionsByID: true,
};

const optimisticData = [
Expand Down Expand Up @@ -376,7 +375,6 @@ function openReport(reportID, participantList = [], newReportObject = {}) {
const params = {
reportID,
emailList: participantList ? participantList.join(',') : '',
shouldKeyReportActionsByID: true,
};

// If we are creating a new report, we need to add the optimistic report data and a report action
Expand Down Expand Up @@ -440,7 +438,6 @@ function reconnect(reportID) {
API.write('ReconnectToReport',
{
reportID,
shouldKeyReportActionsByID: true,
},
{
optimisticData: [{
Expand Down Expand Up @@ -517,7 +514,6 @@ function openPaymentDetailsPage(chatReportID, iouReportID) {
API.read('OpenPaymentDetailsPage', {
reportID: chatReportID,
iouReportID,
shouldKeyReportActionsByID: true,
}, {
optimisticData: [
{
Expand Down Expand Up @@ -769,7 +765,6 @@ function deleteReportComment(reportID, reportAction) {
const parameters = {
reportID,
reportActionID: reportAction.reportActionID,
shouldKeyReportActionsByID: true,
};
API.write('DeleteComment', parameters, {optimisticData, successData, failureData});
}
Expand Down Expand Up @@ -929,7 +924,6 @@ function editReportComment(reportID, originalReportAction, textForNewComment) {
reportID,
reportComment: htmlForNewComment,
reportActionID,
shouldKeyReportActionsByID: true,
};
API.write('UpdateComment', parameters, {optimisticData, successData, failureData});
}
Expand Down

0 comments on commit fc65409

Please sign in to comment.