Avoid repeating logic at every component render.

Expensify · Apr 13, 2023 · 9754a32 · 9754a32
1 parent 4f995a9
commit 9754a32
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/libs/OptionsListUtils.js b/src/libs/OptionsListUtils.js
@@ -169,7 +169,7 @@ function getPersonalDetailsForLogins(logins, personalDetails) {
 /**
  * Get the participant options for a report.
  * @param {Object} report
- * @param {Array<Object>} personalDetailList
+ * @param {Array<Object>} personalDetails
  * @returns {Array}
  */
 function getParticipantsOptions(report, personalDetails) {

diff --git a/src/pages/iou/MoneyRequestModal.js b/src/pages/iou/MoneyRequestModal.js
@@ -104,10 +104,6 @@ const Steps = {
 };
 
 const MoneyRequestModal = (props) => {
-    const participantsWithDetails = ReportUtils.isPolicyExpenseChat(props.report)
-        ? OptionsListUtils.getPolicyExpenseReportOptions(props.report)
-        : OptionsListUtils.getParticipantsOptions(props.report, props.personalDetails);
-
     // Skip IOUParticipants step if participants are passed in
     const reportParticipants = lodashGet(props, 'report.participants', []);
     const steps = reportParticipants.length ? [Steps.MoneyRequestAmount, Steps.MoneyRequestConfirm] : [Steps.MoneyRequestAmount, Steps.MoneyRequestParticipants, Steps.MoneyRequestConfirm];
@@ -117,7 +113,11 @@ const MoneyRequestModal = (props) => {
 
     const [previousStepIndex, setPreviousStepIndex] = useState(0);
     const [currentStepIndex, setCurrentStepIndex] = useState(0);
-    const [selectedOptions, setSelectedOptions] = useState(participantsWithDetails);
+    const [selectedOptions, setSelectedOptions] = useState(
+        ReportUtils.isPolicyExpenseChat(props.report)
+            ? OptionsListUtils.getPolicyExpenseReportOptions(props.report)
+            : OptionsListUtils.getParticipantsOptions(props.report, props.personalDetails),
+    );
     const [amount, setAmount] = useState('');
     const [comment, setComment] = useState('');