Skip to content

Commit

Permalink
updates after review
Browse files Browse the repository at this point in the history
  • Loading branch information
narefyev91 committed Jul 3, 2024
1 parent 95ab2ba commit 2696c2c
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,23 @@
import type {StackScreenProps} from '@react-navigation/stack';
import React from 'react';
import {useOnyx} from 'react-native-onyx';
import type {OnyxEntry} from 'react-native-onyx';
import type {FullScreenNavigatorParamList} from '@libs/Navigation/types';
import AccessOrNotFoundWrapper from '@pages/workspace/AccessOrNotFoundWrapper';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import type SCREENS from '@src/SCREENS';
import type {WorkspaceCardsList} from '@src/types/onyx';
import {isEmptyObject} from '@src/types/utils/EmptyObject';
import WorkspaceCardPageEmptyState from './WorkspaceCardPageEmptyState';
import WorkspaceExpensifyCardPage from './WorkspaceExpensifyCardPage';

type WorkspaceCardPageFeedProps = StackScreenProps<FullScreenNavigatorParamList, typeof SCREENS.WORKSPACE.EXPENSIFY_CARD>;

// TODO: remove when Onyx data is available
const cardsList: OnyxEntry<WorkspaceCardsList> = {};

function WorkspaceCardPageFeed({route}: WorkspaceCardPageFeedProps) {
const policyID = route.params.policyID ?? '-1';
const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${policyID}_${CONST.EXPENSIFY_CARD.BANK}`);
// const policyID = route.params.policyID ?? '-1';
// const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${policyID}_${CONST.EXPENSIFY_CARD.BANK}`);

return (
<AccessOrNotFoundWrapper
Expand All @@ -22,8 +26,8 @@ function WorkspaceCardPageFeed({route}: WorkspaceCardPageFeedProps) {
featureName={CONST.POLICY.MORE_FEATURES.ARE_EXPENSIFY_CARDS_ENABLED}
>
{/* After BE will be implemented we will probably want to have ActivityIndicator during fetch for cardsList */}
{!cardsList && <WorkspaceCardPageEmptyState route={route} />}
{cardsList && <WorkspaceExpensifyCardPage route={route} />}
{isEmptyObject(cardsList) && <WorkspaceCardPageEmptyState route={route} />}
{!isEmptyObject(cardsList) && <WorkspaceExpensifyCardPage route={route} />}
</AccessOrNotFoundWrapper>
);
}
Expand Down

0 comments on commit 2696c2c

Please sign in to comment.