refactor the existing createOptimistic... functions to buildOptimisti…

…c...
Expensify · Sep 7, 2022 · 22c5612 · 22c5612
1 parent 4147659
commit 22c5612
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 15 deletions.
diff --git a/src/libs/actions/Policy.js b/src/libs/actions/Policy.js
@@ -810,7 +810,7 @@ function createWorkspace() {
         expenseChatReportID,
         expenseChatData,
         expenseReportActionData,
-    } = Report.createOptimisticWorkspaceChats(policyID, workspaceName);
+    } = Report.buildOptimisticWorkspaceChats(policyID, workspaceName);
 
     // We need to use makeRequestWithSideEffects as we try to redirect to the policy right after creation
     // The policy hasn't been merged in Onyx data at this point, leading to an intermittent Not Found screen

diff --git a/src/libs/actions/Report.js b/src/libs/actions/Report.js
@@ -586,7 +586,7 @@ function fetchAllReports(
 }
 
 /**
- * Creates an optimistic chat report with a randomly generated reportID and as much information as we currently have
+ * Builds an optimistic chat report with a randomly generated reportID and as much information as we currently have
  *
  * @param {Array} participantList
  * @param {String} reportName
@@ -597,7 +597,7 @@ function fetchAllReports(
  * @param {String} oldPolicyName
  * @returns {Object}
  */
-function createOptimisticChatReport(
+function buildOptimisticChatReport(
     participantList,
     reportName = 'Chat Report',
     chatType = '',
@@ -632,7 +632,7 @@ function createOptimisticChatReport(
 }
 
 /*
- * Creates an optimistic IOU report with a randomly generated reportID
+ * Builds an optimistic IOU report with a randomly generated reportID
  */
 function buildOptimisticIOUReport(total, chatReportID, currency, locale) {
     const formattedTotal = NumberFormatUtils.format(locale,
@@ -659,7 +659,7 @@ function buildOptimisticIOUReport(total, chatReportID, currency, locale) {
  * @param {String} ownerEmail
  * @returns {Object}
  */
-function createOptimisticCreatedReportAction(ownerEmail) {
+function buildOptimisticCreatedReportAction(ownerEmail) {
     return {
         0: {
             actionName: CONST.REPORT.ACTIONS.TYPE.CREATED,
@@ -699,8 +699,8 @@ function createOptimisticCreatedReportAction(ownerEmail) {
  * @param {String} policyName
  * @returns {Object}
  */
-function createOptimisticWorkspaceChats(policyID, policyName) {
-    const announceChatData = createOptimisticChatReport(
+function buildOptimisticWorkspaceChats(policyID, policyName) {
+    const announceChatData = buildOptimisticChatReport(
         [currentUserEmail],
         CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE,
         CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE,
@@ -710,15 +710,15 @@ function createOptimisticWorkspaceChats(policyID, policyName) {
         policyName,
     );
     const announceChatReportID = announceChatData.reportID;
-    const announceReportActionData = createOptimisticCreatedReportAction(announceChatData.ownerEmail);
+    const announceReportActionData = buildOptimisticCreatedReportAction(announceChatData.ownerEmail);
 
-    const adminsChatData = createOptimisticChatReport([currentUserEmail], CONST.REPORT.WORKSPACE_CHAT_ROOMS.ADMINS, CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, policyID, null, false, policyName);
+    const adminsChatData = buildOptimisticChatReport([currentUserEmail], CONST.REPORT.WORKSPACE_CHAT_ROOMS.ADMINS, CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, policyID, null, false, policyName);
     const adminsChatReportID = adminsChatData.reportID;
-    const adminsReportActionData = createOptimisticCreatedReportAction(adminsChatData.ownerEmail);
+    const adminsReportActionData = buildOptimisticCreatedReportAction(adminsChatData.ownerEmail);
 
-    const expenseChatData = createOptimisticChatReport([currentUserEmail], '', CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, currentUserEmail, true, policyName);
+    const expenseChatData = buildOptimisticChatReport([currentUserEmail], '', CONST.REPORT.CHAT_TYPE.POLICY_EXPENSE_CHAT, policyID, currentUserEmail, true, policyName);
     const expenseChatReportID = expenseChatData.reportID;
-    const expenseReportActionData = createOptimisticCreatedReportAction(expenseChatData.ownerEmail);
+    const expenseReportActionData = buildOptimisticCreatedReportAction(expenseChatData.ownerEmail);
 
     return {
         announceChatReportID,
@@ -1655,10 +1655,10 @@ export {
     readOldestAction,
     openReport,
     openPaymentDetailsPage,
-    createOptimisticWorkspaceChats,
-    createOptimisticChatReport,
+    buildOptimisticWorkspaceChats,
+    buildOptimisticChatReport,
     buildOptimisticIOUReport,
-    createOptimisticCreatedReportAction,
+    buildOptimisticCreatedReportAction,
     updatePolicyRoomName,
     clearPolicyRoomNameErrors,
 };