Make sure we round properly wallet transfer fee and balance for display

Expensify · Feb 10, 2022 · 1228648 · 1228648
1 parent bdf3a74
commit 1228648
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/libs/PaymentUtils.js b/src/libs/PaymentUtils.js
@@ -94,15 +94,15 @@ function formatPaymentMethods(bankAccountList, cardList, payPalMeUsername = '',
 }
 
 /**
- * @param {Number} currentBalance
+ * @param {Number} currentBalance, in cents
  * @param {String} methodType
- * @returns {Number}
+ * @returns {Number} the fee, in cents
  */
 function calculateWalletTransferBalanceFee(currentBalance, methodType) {
     const transferMethodTypeFeeStructure = methodType === CONST.WALLET.TRANSFER_METHOD_TYPE.INSTANT
         ? CONST.WALLET.TRANSFER_METHOD_TYPE_FEE.INSTANT
         : CONST.WALLET.TRANSFER_METHOD_TYPE_FEE.ACH;
-    const calculateFee = (currentBalance * transferMethodTypeFeeStructure.RATE) / 100;
+    const calculateFee = Math.ceil(currentBalance * (transferMethodTypeFeeStructure.RATE / 100));
     return Math.max(calculateFee, transferMethodTypeFeeStructure.MINIMUM_FEE);
 }
 

diff --git a/tests/unit/PaymentUtilsTest.js b/tests/unit/PaymentUtilsTest.js
@@ -0,0 +1,9 @@
+import CONST from '../../src/CONST';
+
+const paymentUtils = require('../../src/libs/PaymentUtils');
+
+describe('PaymentUtils', () => {
+    it('Test rounding wallet transfer instant fee', () => {
+        expect(paymentUtils.calculateWalletTransferBalanceFee(2100, CONST.WALLET.TRANSFER_METHOD_TYPE.INSTANT)).toBe(32);
+    });
+});