Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use official graphql java 22 version #1980

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

eocantu
Copy link
Contributor

@eocantu eocantu commented Jun 18, 2024

📝 Description

Follow up to #1967 to use an official graphql java release.

@@ -9,6 +9,7 @@ dependencies {
api(libs.graphql.java) {
exclude(group = "com.graphql-java", module = "java-dataloader")
}
testImplementation(projects.graphqlKotlinServer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to bring this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to have access to the dataFetchingEnvironmentExtensions in the tests.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is somewhat problematic as you end up with cyclic dependency -> i.e. graphql-kotlin-server depends on graphql-kotlin-dataloader-instrumentation as API dependency (link) and we depend here on the server as a test dependency.

Guessing Gradle is smart enough to handle the API vs test dependency.... but I'd avoid it and either copy over the extension locally to one of the tests or simply do what extension does....

@dariuszkuc dariuszkuc merged commit 793c5ed into ExpediaGroup:master Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants