Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radiation changes #54

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

ntlewis
Copy link
Contributor

@ntlewis ntlewis commented Jun 29, 2018

A few changes are in here:

  1. Multiply insolation in rrtm_radiation and two_stream_gray_rad by rrsun so that non-zero eccentricity has an effect.

  2. Add deallocation for h2o input file interpolation to rrtm_radiation (was missing before).

  3. Add option to prescribe h2o to two_stream_gray_rad from input file using the interpolator.

  4. Add Nakajima 1992 definition of longwave optical depths to two_stream_gray_rad as additional gray radiation scheme option. Ref: https://journals.ametsoc.org/doi/abs/10.1175/1520-0469(1992)049%3C2256:ASOTGE%3E2.0.CO;2.

All additions have been tested.

@ntlewis
Copy link
Contributor Author

ntlewis commented Jun 29, 2018

I didn't intend to pass across the `Add T21 spectral resolution to experiment.py' commit, as it has a missing curly brace after the resolution definition. How do I remedy this?

@jamesp
Copy link
Contributor

jamesp commented Jun 30, 2018 via email

@ntlewis
Copy link
Contributor Author

ntlewis commented Jul 3, 2018

Issue fixed. I left in the T21 resolution definition, but added the missing brace, as I figured it could be useful to someone at some point.

@jamesp
Copy link
Contributor

jamesp commented Jul 3, 2018

Great. Yes - definitely a useful addition, thanks for doing that

Copy link
Contributor

@jamesp jamesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

  • There is a core dump that is in the commit? Please delete. How big is this file? If it's huge we might need to scrub it from the history.
  • Are the land masks generic, or specific to you? If specific, please remove or document.
  • See the inline comments below. I think you have committed a couple of temp files that could do with being removed.

exp/test_cases/MiMA/#MiMA_test_case.py# Outdated Show resolved Hide resolved
src/shared/constants/#constants.F90# Outdated Show resolved Hide resolved
@ntlewis
Copy link
Contributor Author

ntlewis commented Sep 20, 2018

@jamesp My apologies for some of the garbage thats ended up in this commit! I'll work through cleaning it up in the next week or two.

@ntlewis
Copy link
Contributor Author

ntlewis commented Feb 27, 2019

@jamesp I think I've tidied this up now so should be ready to merge 😄

Copy link
Contributor

@jamesp jamesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @ntlewis! Can you just confirm you've sorted all the merge artefacts in two_stream_gray_rad?

@dennissergeev dennissergeev added phys:rad Physics: radiation priority:low Low-priority task labels May 6, 2020
@rosscastle rosscastle added the model_dev Isca development for new features, but not fixes label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model_dev Isca development for new features, but not fixes phys:rad Physics: radiation priority:low Low-priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants