Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when establishing a TCP connection #69

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

hayley-jean
Copy link
Member

Set the connection back into connecting mode so that the connection is retried when an exception is thrown in EstablishTcpConnection.

This is needed because DNS resolution can fail when creating the TCP Connection.

Set the connection back into connecting mode so that the connection is
retried when an exception is thrown in EstablishTcpConnection.

This is needed because DNS resolution can fail when creating the TCP
Connection.
Copy link
Member

@shaan1337 shaan1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good - reconnects after fix 👍

@shaan1337 shaan1337 merged commit f29fb7f into master Nov 14, 2022
@shaan1337 shaan1337 deleted the hayley-jean/establish-connection-error branch November 14, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants