StreamRevision Updates #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yreynhout
reviewed
Jul 3, 2020
yreynhout
reviewed
Jul 3, 2020
yreynhout
reviewed
Jul 3, 2020
yreynhout
reviewed
Jul 6, 2020
| @@ -23,6 +23,7 @@ namespace EventStore.Client { | |||
| _value = value; | |||
| } | |||
|
|
|||
| public StreamRevision Next() => this + 1; | |||
There was a problem hiding this comment.
Do you want to guard ulong.MaxValue + 1 ? You could do something like this:
if (_value == ulong.MaxValue) then throw new InvalidOperationException("StreamRevision.None does not have a next value.");
return this + 1;
There was a problem hiding this comment.
thefringeninja
force-pushed
the
forward-pass
branch
2 times, most recently
from
ba57527
to
9c7fb20
Compare
pgermishuys
previously approved these changes
Jul 20, 2020
|
This requires rebase after the recent merge @thefringeninja but looks good otherwise. |
thefringeninja
force-pushed
the
forward-pass
branch
from
9c7fb20
to
d4848af
Compare
hayley-jean
approved these changes
Jul 20, 2020
pgermishuys
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: Convert from StreamPosition to StreamRevision; StreamRevision on IWriteResult