Detect Server Capabilities #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thefringeninja
commented
Nov 30, 2021
•
thefringeninja
commented
- add server capabilities checks for persistent subscriptions to all and batch append
- remove net48 as a target
thefringeninja
force-pushed
the
b0rked-append
branch
6 times, most recently
from
1b07679
to
be66145
Compare
thefringeninja
changed the title
thefringeninja
force-pushed
the
b0rked-append
branch
2 times, most recently
from
7b022b7
to
908de93
Compare
YoEight
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Nice work, LGTM overall.
My only concern is that feature introduces a lot of branching that seems to be avoidable.
@timothycoleman convinced me I was wrong here.
src/EventStore.Client.PersistentSubscriptions/PersistentSubscription.cs
Outdated
Show resolved
Hide resolved
| @@ -64,8 +64,6 @@ public class EventStoreTestServer : IEventStoreTestServer { | |||
| .WithName(ContainerName) | |||
| .MountVolume(_hostCertificatePath, "/etc/eventstore/certs", MountType.ReadOnly) | |||
| .ExposePort(2113, 2113) | |||
| //.KeepContainer() | |||
| //.KeepRunning() | |||
There was a problem hiding this comment.
lets keep these i think
thefringeninja
force-pushed
the
b0rked-append
branch
from
908de93
to
f1016c3
Compare
thefringeninja
force-pushed
the
b0rked-append
branch
from
c3d7238
to
312dfa5
Compare
- add timeouts to append_to_stream_retry tests - increase timeouts on security tests
- ensure calls are disposed - rediscovery on server not available - client reusable after discovery or server caps failure Co-authored-by: Timothy Coleman <timothy.coleman@gmail.com>
timothycoleman
force-pushed
the
b0rked-append
branch
from
312dfa5
to
fc06d89
Compare
timothycoleman
force-pushed
the
b0rked-append
branch
from
81610b4
to
e7d5d21
Compare
|
TalAloni/StandardSocketsHttpHandler#8 could fix our issue on |
|
See TalAloni/StandardSocketsHttpHandler#9 for follow up. |
YoEight
previously approved these changes
Jan 24, 2022
thefringeninja
force-pushed
the
b0rked-append
branch
from
252bf35
to
953e9ab
Compare
|
this pr also improves server discovery:
|
YoEight
approved these changes
Jan 26, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.