fix samples

EventStore · Nov 11, 2022 · 715a628 · 715a628
1 parent a827cfd
commit 715a628
Show file tree

Hide file tree

Showing 13 changed files with 8 additions and 18 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -38,7 +38,12 @@ jobs:
 
   build-samples:
     timeout-minutes: 5
+    name: build-samples/${{ matrix.framework }}
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        framework: [ net5.0, net6.0, net7.0 ]
     services:
       esdb:
         image: ghcr.io/eventstore/eventstore:lts
@@ -67,7 +72,7 @@ jobs:
       - name: Run
         shell: bash
         run: |
-          find samples/ -type f -iname "*.csproj" -print0 | xargs -0L1 dotnet run --project
+          find samples/ -type f -iname "*.csproj" -print0 | xargs -0L1 dotnet run --framework ${{ matrix.framework }} --project
 
   test:
     timeout-minutes: 10

diff --git a/samples/Directory.Build.props b/samples/Directory.Build.props
@@ -2,5 +2,7 @@
 	<PropertyGroup>
 		<Nullable>enable</Nullable>
 		<NullableContextOptions>enable</NullableContextOptions>
+		<OutputType>Exe</OutputType>
+		<TargetFrameworks>net5.0;net6.0;net7.0</TargetFrameworks>
 	</PropertyGroup>
 </Project>
diff --git a/samples/appending-events/appending-events.csproj b/samples/appending-events/appending-events.csproj
@@ -2,7 +2,6 @@
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>net5.0</TargetFramework>
         <RootNamespace>appending_events</RootNamespace>
     </PropertyGroup>
 

diff --git a/samples/connecting-to-a-cluster/connecting-to-a-cluster.csproj b/samples/connecting-to-a-cluster/connecting-to-a-cluster.csproj
@@ -2,7 +2,6 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFramework>net5.0</TargetFramework>
 		<RootNamespace>connecting_to_a_cluster</RootNamespace>
 	</PropertyGroup>
 

diff --git a/samples/connecting-to-a-single-node/connecting-to-a-single-node.csproj b/samples/connecting-to-a-single-node/connecting-to-a-single-node.csproj
@@ -2,7 +2,6 @@
 
 	<PropertyGroup>
 		<OutputType>Exe</OutputType>
-		<TargetFramework>net5.0</TargetFramework>
 	</PropertyGroup>
 
 	<ItemGroup>

diff --git a/samples/persistent-subscriptions/persistent-subscriptions.csproj b/samples/persistent-subscriptions/persistent-subscriptions.csproj
@@ -2,7 +2,6 @@
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
-        <TargetFramework>netcoreapp3.1</TargetFramework>
         <RootNamespace>persistent_subscriptions</RootNamespace>
     </PropertyGroup>
 

diff --git a/samples/projection-management/projection-management.csproj b/samples/projection-management/projection-management.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <OutputType>Exe</OutputType>
-    <TargetFramework>net5.0</TargetFramework>
     <RootNamespace>projection_management</RootNamespace>
   </PropertyGroup>
 

diff --git a/samples/quick-start/quick-start.csproj b/samples/quick-start/quick-start.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<OutputType>Exe</OutputType>
-		<TargetFramework>net5.0</TargetFramework>
 		<RootNamespace>quick_start</RootNamespace>
 	</PropertyGroup>
 

diff --git a/samples/reading-events/reading-events.csproj b/samples/reading-events/reading-events.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <OutputType>Exe</OutputType>
-        <TargetFramework>net5.0</TargetFramework>
         <RootNamespace>reading_events</RootNamespace>
     </PropertyGroup>
 

diff --git a/samples/secure-with-tls/secure-with-tls.csproj b/samples/secure-with-tls/secure-with-tls.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <OutputType>Exe</OutputType>
-        <TargetFramework>net5.0</TargetFramework>
         <RootNamespace>secure_with_tls</RootNamespace>
     </PropertyGroup>
 

diff --git a/samples/server-side-filtering/server-side-filtering.csproj b/samples/server-side-filtering/server-side-filtering.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <OutputType>Exe</OutputType>
-        <TargetFramework>net5.0</TargetFramework>
         <RootNamespace>server_side_filtering</RootNamespace>
     </PropertyGroup>
 

diff --git a/samples/setting-up-dependency-injection/setting-up-dependency-injection.csproj b/samples/setting-up-dependency-injection/setting-up-dependency-injection.csproj
@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
 
 	<PropertyGroup>
-		<TargetFramework>net5.0</TargetFramework>
 		<RootNamespace>setting_up_dependency_injection</RootNamespace>
 	</PropertyGroup>
 

diff --git a/samples/subscribing-to-streams/subscribing-to-streams.csproj b/samples/subscribing-to-streams/subscribing-to-streams.csproj
@@ -1,8 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <OutputType>Exe</OutputType>
-        <TargetFramework>net5.0</TargetFramework>
         <RootNamespace>subscribing_to_streams</RootNamespace>
     </PropertyGroup>