Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wsl: Get the distro icon from the package family name #9749

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

microhobby
Copy link
Contributor

All the WSL distributions installed from the Microsoft Store have a package family name that can be used to get the distribution icon.

For example, this way even distributions that are not in the Tabby SVG list can show the distro icon:

image

Copy link
Owner

@Eugeny Eugeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, otherwise LGTM, thanks 👍

tabby-electron/src/shells/wsl.ts Outdated Show resolved Hide resolved
tabby-electron/src/shells/wsl.ts Outdated Show resolved Hide resolved
All the WSL distributions that was installed from the Microsoft Store
have a package family name that can be used to get the icon of the
distribution.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
@microhobby microhobby requested a review from Eugeny July 2, 2024 11:45
@Eugeny Eugeny merged commit 223d854 into Eugeny:master Jul 9, 2024
10 checks passed
@Eugeny
Copy link
Owner

Eugeny commented Jul 9, 2024

Thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants