host: Add OctoClock Python API #720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
mbr0wn
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
This is fantastic, @prefixFelix. It'll take us a bit to review, test, and merge but thanks for this contribution.
|
This has been merged into master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
An extension of the Python API to enable access to all OctoClock methods. The code is based on the existing multi_usrp implementation.
Related Issue
The question of a Python implementation for the OctoClock was mentioned here in the mailing list.
Which devices/areas does this affect?
The changes affect the OctoClock and OctoClock-G.
Testing Done
The provided test
multi_usrp_clock_test.pywas successfully executed with an OctoClock-G CDA-2990. Please note that the test was not run with more than one OctoClock as I only have one currently available.Checklist
MPM compat, noc_shell, specific RFNoC block, ...)