Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create model compression tools #452

Merged
merged 6 commits into from
Jan 1, 2024

Conversation

zhimin-z
Copy link
Collaborator

@zhimin-z zhimin-z commented Oct 29, 2023

This module aims to add compression tools specifically designed for machine learning models.
Is it good to ship? @axsaucedo

Copy link
Collaborator

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding @zhimin-z, I have certainly seen a rise of model optimization, compilation and compression libraries (also closed source like https://www.modular.com/max/mojo) which I agree would be relevant to have in a new section, as the "optimized computation" would not encompass these tools - my suggestion would be to extent the title to something more broad such as "model optimization, compilation and compression" - other than that look good

@zhimin-z
Copy link
Collaborator Author

zhimin-z commented Jan 1, 2024

Thanks for adding @zhimin-z, I have certainly seen a rise of model optimization, compilation and compression libraries (also closed source like https://www.modular.com/max/mojo) which I agree would be relevant to have in a new section, as the "optimized computation" would not encompass these tools - my suggestion would be to extent the title to something more broad such as "model optimization, compilation and compression" - other than that look good

Fixed!

Copy link
Collaborator

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axsaucedo axsaucedo merged commit 9dba17c into EthicalML:master Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants