Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(**/package.json): bump ArcGIS Rest Js #66

Merged
merged 3 commits into from
Sep 20, 2018

Conversation

dbouwman
Copy link
Member

AFFECTS PACKAGES:
@esri/hub-annotations
@esri/hub-auth
@esri/hub-common
@esri/hub-domains
@esri/hub-initiatives
@esri/hub-sites
@esri/hub-solutions

@coveralls
Copy link

coveralls commented Sep 19, 2018

Pull Request Test Coverage Report for Build 258

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.897%

Totals Coverage Status
Change from base Build 254: 0.0%
Covered Lines: 802
Relevant Lines: 802

💛 - Coveralls

CHANGELOG.md Outdated
@@ -7,10 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### [Unreleased][HEAD]

## [1.2.0] - September 19th 2018

## [1.2.0] - September 17th 2018
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two of these now.

CHANGELOG.md Outdated
@@ -87,5 +89,6 @@ Initial Release
[1.0.1]: https://github.com/Esri/hub.js/compare/v1.0.0...v1.0.1 "v1.0.1"
[1.1.0]: https://github.com/Esri/hub.js/compare/v1.0.1...v1.1.0 "v1.1.0"
[1.1.1]: https://github.com/Esri/hub.js/compare/v1.1.0...v1.1.1 "v1.1.1"
[1.2.0]: https://github.com/Esri/hub.js/compare/v1.1.1...1.2.0 "1.2.0"
[1.2.0]: https://github.com/Esri/hub.js/compare/v1.1.1...v1.2.0 "v1.2.0"
[1.2.0]: https://github.com/Esri/hub.js/compare/v1.2.0...1.2.0 "1.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.

my instinct is to bump the internal dependencies only in this PR and save the rest for the actual release script.

AFFECTS PACKAGES:
@esri/hub-annotations
@esri/hub-auth
@esri/hub-common
@esri/hub-domains
@esri/hub-initiatives
@esri/hub-sites
@esri/hub-solutions
@dbouwman dbouwman dismissed jgravois’s stale review September 19, 2018 22:47

fixes have been made

@tomwayson tomwayson merged commit 788dcad into master Sep 20, 2018
@tomwayson tomwayson deleted the chore/bump-arcgis-rest branch September 20, 2018 00:26
tomwayson added a commit that referenced this pull request Sep 20, 2018
jgravois added a commit that referenced this pull request Sep 20, 2018
after pulling #66 and running locally, these package.json files were …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants