chore(hub-teams): remove pre 9.1 well known teams #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 88 428 +340
Lines 1314 6000 +4686
Branches 193 945 +752
===========================================
+ Hits 1314 6000 +4686
Continue to review full report at Codecov.
|
dbouwman
approved these changes
Jun 29, 2021
| ? PRE_9_1_WELLKNOWNTEAMS | ||
| : WELLKNOWNTEAMS; | ||
| /* tslint:disable no-console */ | ||
| console.warn("portalApiVersion is deprecated and will be removed at v9.0.0"); |
There was a problem hiding this comment.
Add the function name to the warning... otherwise, it's hard to know where this is coming from
| ? PRE_9_1_WELLKNOWNTEAMS | ||
| : WELLKNOWNTEAMS; | ||
| /* tslint:disable no-console */ | ||
| console.warn("portalApiVersion is deprecated and will be removed at v9.0.0"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes pre 9.1 well known teams
Instructions for testing:
Screenshot/GIF:
Closes Issues: # (if appropriate)
ran commit script (
npm run c)Note If you don't run the commit script at least once, the Semantic Pull Request check will fail. Save yourself some time, and run
npm run cand follow the prompts.For more information see the README