136998 - Adjust method signatures to accept ids instead of models

[rweber-esri]

A follow-up PR to my original PR for hoisting survey sharing logic.

1. Addresses some cleanup in the surveys package, e.g. moving get-* methods out of sharing dir and into a new items dir
2. Changes some of the get-* method signatures to accept an ID string vs IModel.
3. Changes getStakeholderModel to use the Survey2Data relationship and accept the Form ID instead of a Fieldworker ID
4. Improved getSurveyModels performance by make the getInputFeatureServiceModel and getStakeholderModel calls concurrent (point of More initiatives #3 above).

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@3317a15). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master      #286   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       321           
  Lines             ?      3761           
  Branches          ?       491           
==========================================
  Hits              ?      3761           
  Misses            ?         0           
  Partials          ?         0           

Impacted Files	Coverage Δ
...rveys/src/items/get-input-feature-service-model.ts	100.00% <ø> (ø)
...t-source-feature-service-model-from-fieldworker.ts	100.00% <ø> (ø)
packages/surveys/src/sharing/index.ts	100.00% <ø> (ø)
packages/surveys/src/index.ts	100.00% <100.00%> (ø)
...ackages/surveys/src/items/get-stakeholder-model.ts	100.00% <100.00%> (ø)
packages/surveys/src/items/get-survey-models.ts	100.00% <100.00%> (ø)
packages/surveys/src/items/index.ts	100.00% <100.00%> (ø)
...s/surveys/src/sharing/get-group-sharing-details.ts	100.00% <100.00%> (ø)
packages/surveys/src/sharing/set-access.ts	100.00% <100.00%> (ø)
packages/surveys/src/sharing/share-with-group.ts	100.00% <100.00%> (ø)
... and 322 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3317a15...ee06d1c. Read the comment docs.

[drewdaemon]

Nice. Usually we have used getModelFromOptions to allow the client to use either an ID or a model in functions that require an item model, but it looks like it might not make sense in your case(?) @rweber-esri

[rweber-esri]

Nice. Usually we have used getModelFromOptions to allow the client to use either an ID or a model in functions that require an item model, but it looks like it might not make sense in your case(?) @rweber-esri

Good observation @drewctate. Admittedly, this is something I went back and forth on. Ultimately, these methods don't benefit from accepting a full model object (we don't need groups, data, etc) and the existing shareItemToGroups and unshareItemFromGroups methods from the hub-common package use a simplified interface that accepts id strings, so went this direction to be consistent on the sharing front.