Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): change content settings schema's extract toggle to be a tile select #1681

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

sonofflynn89
Copy link
Contributor

@sonofflynn89 sonofflynn89 commented Oct 7, 2024

  1. Description:

Part of https://devtopia.esri.com/dc/hub/issues/11504

Changes the "extract" toggle in the content settings schema to be a "download system" tile select

  1. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  2. used semantic commit messages

  3. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

…toggle to be a tile select and

affects: @esri/hub-common
affects: @esri/hub-common
@sonofflynn89 sonofflynn89 changed the title F/11504 change extract toggle to tile select feat(hub-common): change content settings schema's extract toggle to be a tile select Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2626a26) to head (938202b).
Report is 91 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1681    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          992      1012    +20     
  Lines        17979     18483   +504     
  Branches      3199      3317   +118     
==========================================
+ Hits         17979     18483   +504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@abp6318 abp6318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much cleaner! Good stuff!

@sonofflynn89 sonofflynn89 merged commit 6445470 into master Oct 8, 2024
7 checks passed
@sonofflynn89 sonofflynn89 deleted the f/11504-change-extract-toggle-to-tile-select branch October 8, 2024 15:08
esri-dcdev-2 pushed a commit that referenced this pull request Oct 8, 2024
# @esri/hub-common [14.210.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.209.0...@esri/hub-common@14.210.0) (2024-10-08)

### Features

* **hub-common:** change content settings schema's extract toggle to be a tile select ([#1681](#1681)) ([6445470](6445470))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants