Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: showInfoBanner for user org settings #1676

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

benstoltz
Copy link
Member

@benstoltz benstoltz commented Oct 3, 2024

  1. Description: Adds a showInfoBanner section to User Org Settings. Also adds the save logic.

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@benstoltz benstoltz changed the title feat: showInfoBanner set up in schema && in hubuser feat: showInfoBanner for user org settings Oct 3, 2024
Copy link
Contributor

@jordantsanz jordantsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benstoltz benstoltz merged commit ee32bb6 into master Oct 4, 2024
5 checks passed
@benstoltz benstoltz deleted the feat/11440-org-info-banner branch October 4, 2024 13:05
esri-dcdev-2 pushed a commit that referenced this pull request Oct 4, 2024
# @esri/hub-common [14.205.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.204.0...@esri/hub-common@14.205.0) (2024-10-04)

### Features

* showInfoBanner for user org settings ([#1676](#1676)) ([ee32bb6](ee32bb6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants