Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group schema and create group uischema #1666

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

mjuniper
Copy link
Member

affects: @esri/hub-common

  1. Description: Updates to group json schema and create group uiSchema.

  2. Closes Issues: #11368

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@mjuniper mjuniper force-pushed the b/11368-create-groups branch 2 times, most recently from bdf763b to 074e402 Compare September 27, 2024 17:20
Copy link
Member

@dbouwman dbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me; would be good to add comments to IHubGroup props so the docs update :)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2626a26) to head (20433ac).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master     #1666    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          992      1009    +17     
  Lines        17979     18329   +350     
  Branches      3199      3275    +76     
==========================================
+ Hits         17979     18329   +350     
Flag Coverage Δ
100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjuniper mjuniper merged commit d856c49 into master Sep 27, 2024
7 checks passed
@mjuniper mjuniper deleted the b/11368-create-groups branch September 27, 2024 20:33
esri-dcdev-2 pushed a commit that referenced this pull request Sep 27, 2024
# @esri/hub-common [14.198.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.197.0...@esri/hub-common@14.198.0) (2024-09-27)

### Features

* group schema and create group uischema ([#1666](#1666)) ([d856c49](d856c49))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants