Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): add layout field for list and map views to event ga… #1663

Merged

Conversation

rweber-esri
Copy link
Contributor

…llery card schema and uiSchema

affects: @esri/hub-common

ISSUES CLOSED: 11024

  1. Description:
  • Adds layout field to the events gallery card editor schema & uiSchema
  1. Instructions for testing:

  2. Closes Issues: #11024

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

…llery card schema and uiSchema

affects: @esri/hub-common

ISSUES CLOSED: 11024
affects: @esri/hub-common

ISSUES CLOSED: 11024
ISSUES CLOSED: 11024
@rweber-esri rweber-esri force-pushed the f/11024-add-layout-field-to-event-gallery-card-schema branch from 61bcbb1 to 1e2d039 Compare September 24, 2024 20:00
Copy link
Contributor

@juliannaeapicella juliannaeapicella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending successful tests

…ion objects to IHubLocation obj

affects: @esri/hub-common

ISSUES CLOSED: 11024
@rweber-esri rweber-esri merged commit 78f2d8c into master Sep 25, 2024
5 checks passed
@rweber-esri rweber-esri deleted the f/11024-add-layout-field-to-event-gallery-card-schema branch September 25, 2024 15:40
esri-dcdev-2 pushed a commit that referenced this pull request Sep 25, 2024
# @esri/hub-common [14.193.0](https://github.com/Esri/hub.js/compare/@esri/hub-common@14.192.0...@esri/hub-common@14.193.0) (2024-09-25)

### Features

* **hub-common:** add layout field for list and map views to event ga… ([#1663](#1663)) ([78f2d8c](78f2d8c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants