-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hub-sites): getMembers call uses filter instead of q in query #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarvinPerry
changed the title
[DNM]fix(hub-sites): getMembers call uses filter instead of q in query
fix(hub-sites): getMembers call uses filter instead of q in query
Aug 21, 2024
affects: @esri/hub-sites ISSUES CLOSED: 11160
MarvinPerry
force-pushed
the
b/get-members-update
branch
from
August 21, 2024 17:06
f869177
to
dbec8a3
Compare
MarvinPerry
changed the title
fix(hub-sites): getMembers call uses filter instead of q in query
[DNM]fix(hub-sites): getMembers call uses filter instead of q in query
Aug 21, 2024
MarvinPerry
force-pushed
the
b/get-members-update
branch
from
August 21, 2024 20:22
4dd947b
to
cf2de84
Compare
MarvinPerry
force-pushed
the
b/get-members-update
branch
from
August 21, 2024 20:46
cf2de84
to
bd8e96c
Compare
MarvinPerry
force-pushed
the
b/get-members-update
branch
from
August 22, 2024 03:25
10783b5
to
34559cf
Compare
MarvinPerry
force-pushed
the
b/get-members-update
branch
from
August 22, 2024 04:10
ffb53dd
to
65cc18c
Compare
vivzhang
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and verified change.
MarvinPerry
changed the title
[DNM]fix(hub-sites): getMembers call uses filter instead of q in query
fix(hub-sites): getMembers call uses filter instead of q in query
Aug 26, 2024
esri-dcdev-2
pushed a commit
that referenced
this pull request
Aug 26, 2024
## @esri/hub-sites [15.0.1](https://github.com/Esri/hub.js/compare/@esri/hub-sites@15.0.0...@esri/hub-sites@15.0.1) (2024-08-26) ### Bug Fixes * **hub-sites:** getMembers call uses filter instead of q in query ([#1633](#1633)) ([39a6c44](39a6c44))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @esri/hub-sites
ISSUES CLOSED: 11160
Description:
Instructions for testing:
Closes Issues: # (if appropriate)
Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide
used semantic commit messages
PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)
updated
peerDependencies
as needed. CRITICAL our automated release system can not be counted on to updatepeerDependencies
so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.