Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hub-sites): getMembers call uses filter instead of q in query #1633

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

MarvinPerry
Copy link
Contributor

@MarvinPerry MarvinPerry commented Aug 21, 2024

affects: @esri/hub-sites

ISSUES CLOSED: 11160

  1. Description:

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@MarvinPerry MarvinPerry added the Draft Draft PR or Issue (don't mark stale) label Aug 21, 2024
@MarvinPerry MarvinPerry marked this pull request as draft August 21, 2024 15:44
@MarvinPerry MarvinPerry changed the title [DNM]fix(hub-sites): getMembers call uses filter instead of q in query fix(hub-sites): getMembers call uses filter instead of q in query Aug 21, 2024
affects: @esri/hub-sites

ISSUES CLOSED: 11160
@MarvinPerry MarvinPerry marked this pull request as ready for review August 21, 2024 17:06
@MarvinPerry MarvinPerry changed the title fix(hub-sites): getMembers call uses filter instead of q in query [DNM]fix(hub-sites): getMembers call uses filter instead of q in query Aug 21, 2024
Copy link
Contributor

@vivzhang vivzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and verified change.

@MarvinPerry MarvinPerry changed the title [DNM]fix(hub-sites): getMembers call uses filter instead of q in query fix(hub-sites): getMembers call uses filter instead of q in query Aug 26, 2024
@MarvinPerry MarvinPerry removed the Draft Draft PR or Issue (don't mark stale) label Aug 26, 2024
@MarvinPerry MarvinPerry merged commit 39a6c44 into master Aug 26, 2024
5 checks passed
@MarvinPerry MarvinPerry deleted the b/get-members-update branch August 26, 2024 18:19
esri-dcdev-2 pushed a commit that referenced this pull request Aug 26, 2024
## @esri/hub-sites [15.0.1](https://github.com/Esri/hub.js/compare/@esri/hub-sites@15.0.0...@esri/hub-sites@15.0.1) (2024-08-26)

### Bug Fixes

* **hub-sites:** getMembers call uses filter instead of q in query ([#1633](#1633)) ([39a6c44](39a6c44))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants