Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PR preview workflow #1141

Merged
merged 12 commits into from
Aug 3, 2023
Merged

chore: add PR preview workflow #1141

merged 12 commits into from
Aug 3, 2023

Conversation

haoliangyu
Copy link
Member

@haoliangyu haoliangyu commented Aug 2, 2023

  1. Description:

This PR adds a new workflow to build and upload package artifacts on each PR commit. Appropriate secrets have been added and you can see the workflow run at https://github.com/Esri/hub.js/actions/runs/5745022738

  1. Instructions for testing:

  2. Closes Issues: #7323 (if appropriate)

  3. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  4. used semantic commit messages

  5. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  6. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@haoliangyu haoliangyu self-assigned this Aug 2, 2023
@haoliangyu haoliangyu changed the title chore: PR preview chore: add PR preview workflow Aug 3, 2023
@haoliangyu haoliangyu marked this pull request as ready for review August 3, 2023 01:02
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1141 (80c7d4e) into master (0ea3d92) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          717       717           
  Lines        12553     12554    +1     
  Branches      2113      2114    +1     
=========================================
+ Hits         12553     12554    +1     

see 2 files with indirect coverage changes

Copy link
Contributor

@sonofflynn89 sonofflynn89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I brought your PR in locally and everything worked great. Really appreciate you doing this 🙏

@haoliangyu haoliangyu merged commit 90082ba into master Aug 3, 2023
9 checks passed
@haoliangyu haoliangyu deleted the f/library-preview branch August 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants