Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): adding view for content edit #1116

Closed
wants to merge 5 commits into from

Conversation

abp6318
Copy link
Contributor

@abp6318 abp6318 commented Jul 13, 2023

Issue: https://devtopia.esri.com/dc/hub/issues/7207

TODO:

  • 100% test coverage
  • Content is editable
  • Content saves
    • title
    • summary
    • description
    • featured image
    • alt text
    • tags
    • categories
  • Tags are being saved even when none are applied -- requires at least one
  1. Description:
    Creating a new view in workspaces for viewing content item's details and editing them.

  2. Instructions for testing:

  • visit /workspace/content/:id/details
  • make edits to properties available
  • save edits
  • repeat with different variations

also

  • test warnings
  1. Closes Issues: #<7207>

  2. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  3. used semantic commit messages

  4. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  5. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@abp6318 abp6318 self-assigned this Jul 13, 2023
Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

I wonder if the featured image fields are meant to edit the thumbnail, or if they are a project specific thing.

packages/common/src/content/_internal/ContentSchema.ts Outdated Show resolved Hide resolved
packages/common/src/content/_internal/ContentSchema.ts Outdated Show resolved Hide resolved
packages/common/src/content/_internal/ContentSchema.ts Outdated Show resolved Hide resolved
},
],
},
// { // TODO: in another PR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to be forward thinking. I suspect that it will need to be added to ContentSchema as well?

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #1116 (9916d4f) into master (46290dc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       685    +3     
  Lines        11870     11892   +22     
  Branches      1999      2001    +2     
=========================================
+ Hits         11870     11892   +22     
Impacted Files Coverage Δ
...ges/common/src/content/_internal/getPropertyMap.ts 100.00% <ø> (ø)
...mon/src/core/schemas/shared/HubItemEntitySchema.ts 100.00% <ø> (ø)
...ages/common/src/content/_internal/ContentSchema.ts 100.00% <100.00%> (ø)
...ommon/src/content/_internal/ContentUiSchemaEdit.ts 100.00% <100.00%> (ø)
...kages/common/src/content/_internal/computeProps.ts 100.00% <100.00%> (ø)
packages/common/src/content/edit.ts 100.00% <100.00%> (ø)
packages/common/src/content/fetch.ts 100.00% <100.00%> (ø)
.../common/src/core/schemas/getEntityEditorSchemas.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Jul 18, 2023
@abp6318 abp6318 removed the Stale Stale issue - update or it will be closed label Jul 19, 2023
@abp6318 abp6318 closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants