feat: add metrics to project capability permissions (#1086)

* feat: add metrics to project capability permissions * feat: project metris edit permissions not owner
Esri · Jun 9, 2023 · f67c836 · f67c836
1 parent e52a79f
commit f67c836
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 33 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/common/src/capabilities/types.ts b/packages/common/src/capabilities/types.ts
@@ -18,12 +18,13 @@ const validCapabilities = [
   "overview",
   "settings",
   "teams",
+  "metrics",
 ] as const;
 
 /**
  * Defines the possible values for Capability
  */
-export type Capability = typeof validCapabilities[number];
+export type Capability = (typeof validCapabilities)[number];
 
 /**
  * Validate a capability. This is used because the libary can be used outside of typescript and we want to be able to return a message is the string passed in is not a valid capability

diff --git a/packages/common/src/projects/_internal/ProjectBusinessRules.ts b/packages/common/src/projects/_internal/ProjectBusinessRules.ts
@@ -11,6 +11,7 @@ export const ProjectDefaultCapabilities: EntityCapabilities = {
   overview: true,
   details: true,
   settings: true,
+  metrics: true,
 };
 
 /**
@@ -35,6 +36,11 @@ export const ProjectCapabilityPermissions: ICapabilityPermission[] = [
     capability: "settings",
     permissions: ["hub:project:owner"],
   },
+  {
+    entity: "project",
+    capability: "metrics",
+    permissions: ["hub:project:edit"],
+  },
 ];
 
 /**

diff --git a/packages/common/src/types.ts b/packages/common/src/types.ts
@@ -335,6 +335,13 @@ export interface ISearchResponse<T> {
   next: (params?: any) => Promise<ISearchResponse<T>>;
 }
 
+/**
+ * BEGIN CONTENT UPLOAD RELATED TYPES
+ * Please note that the below enum/types are duplicated from the AGO
+ * content upload modal. They were brought over for forward compability purposes and changes
+ * to them may impact how our content upload works.
+ */
+
 /**
  * ENUM which defines File extensions.
  */
@@ -1215,3 +1222,6 @@ export const addCreateItemTypes: Record<string, IFileType> = {
     typeKeywords: ["Insights", "Insights Workbook Package"],
   },
 };
+/**
+ * END CONTENT UPLOAD TYPES/ENUMS
+ */