fix(hub-common): fix setProp() throws error when intermediary prop is…

… set to undefined affects: @esri/hub-common
Esri · Dec 22, 2021 · ecaf741 · ecaf741
1 parent a1c2624
commit ecaf741
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/common/src/objects/deep-set.ts b/packages/common/src/objects/deep-set.ts
@@ -15,7 +15,7 @@ export function deepSet(
   let worker = target;
   const lastIdx = parts.length - 1;
   parts.forEach((p, idx) => {
-    if (!worker.hasOwnProperty(p) || worker[p] === null) {
+    if (!worker.hasOwnProperty(p) || worker[p] == null) {
       if (idx === lastIdx) {
         worker[p] = value;
       } else {

diff --git a/packages/common/test/objects/set-prop.test.ts b/packages/common/test/objects/set-prop.test.ts
@@ -18,4 +18,10 @@ describe("setProp", () => {
     setProp(["foo", "bar"], true, obj);
     expect(obj).toEqual({ foo: { bar: true } });
   });
+
+  it("handles intermediary properties that are explicitly set to undefined", () => {
+    const obj = { foo: undefined as any };
+    setProp("foo.bar", true, obj);
+    expect(obj).toEqual({ foo: { bar: true } });
+  });
 });