refactor(hub-sites): remove hub-sites re-exports from hub-common

affects: @esri/hub-common, @esri/hub-sites

BREAKING CHANGE:
remove getTheme(), _addSiteDomains, registerSiteAsApplication, registerBrowserApp from hub-sites

packages/sites/test/get-theme.test.ts → packages/common/test/sites/themes.test.ts

@@ -1,15 +1,14 @@
-import { getTheme } from "../src";
-import { DEFAULT_THEME } from "@esri/hub-common";
+import { DEFAULT_THEME, getOrgDefaultTheme } from "../../src";
 import { IPortal } from "@esri/arcgis-rest-portal";
 
-describe("getTheme", () => {
+describe("getOrgDefaultTheme", () => {
   it("returns default theme if no shared theme", async () => {
-    expect(getTheme({} as IPortal)).toEqual(DEFAULT_THEME);
+    expect(getOrgDefaultTheme({} as IPortal)).toEqual(DEFAULT_THEME);
   });
 
   it("extends default theme ", async () => {
     expect(
-      getTheme({
+      getOrgDefaultTheme({
         portalProperties: {
           sharedTheme: {
             header: {

packages/sites/src/create-site-model-from-template.ts

@@ -2,6 +2,7 @@ import {
   IModelTemplate,
   IHubRequestOptions,
   getHubProduct,
+  getOrgDefaultTheme,
   getProp,
   cloneObject,
   deepSet,
@@ -12,7 +13,6 @@ import {
 } from "@esri/hub-common";
 import { createHubTeams } from "@esri/hub-teams";
 import { HubTeamType } from "@esri/hub-teams";
-import { getTheme } from "./get-theme";
 import { getPortalSiteHostname } from "./get-portal-site-hostname";
 import { getPortalSiteUrl } from "./get-portal-site-url";
 import { _createSiteInitiative } from "./_create-site-initiative";
@@ -104,7 +104,7 @@ export function createSiteModelFromTemplate(
     .then((uniqueSubdomain) => {
       const portal = hubRequestOptions.portalSelf;
       // TODO: Revisit this if/when we do more site templates which we want to maintain their theme
-      settings.solution.theme = getTheme(portal);
+      settings.solution.theme = getOrgDefaultTheme(portal);
       // set site-specific settings properties...
       settings.solution.subdomain = uniqueSubdomain;
       // setup the url properties

packages/sites/src/index.ts

@@ -15,13 +15,10 @@ export * from "./_get-portal-domain-type-keyword";
 export * from "./_ensure-optional-groups-templating";
 export * from "./_ensure-type-and-tags";
 export * from "./get-site-item-type";
-export * from "./_add-site-domains";
 export * from "./_ensure-portal-domain-keyword";
 export * from "./get-site-edit-url";
 export * from "./update-site-application-uris";
 export * from "./update-app-redirect-uris";
-export * from "./register-site-as-application";
-export * from "./register-browser-app";
 export * from "./unlink-site-and-page";
 export * from "./link-site-and-page";
 export * from "./unlink-pages-from-site";
@@ -33,7 +30,6 @@ export * from "./update-site";
 export * from "./create-site";
 export * from "./get-portal-site-url";
 export * from "./get-portal-site-hostname";
-export * from "./get-theme";
 export * from "./_create-site-initiative";
 export * from "./_update-team-tags";
 export * from "./create-site-model-from-template";