Skip to content

Commit

Permalink
fix: small updates to group details schemas
Browse files Browse the repository at this point in the history
  • Loading branch information
juliannemarik committed Aug 18, 2023
1 parent 362a1e6 commit 946aa6f
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 23 deletions.
48 changes: 30 additions & 18 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion packages/common/src/groups/_internal/GroupSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { IConfigurationSchema } from "../../core";
import {
ENTITY_IMAGE_SCHEMA,
ENTITY_NAME_SCHEMA,
ENTITY_SUMMARY_SCHEMA,
} from "../../core/schemas/shared";

export type GroupEditorType = (typeof GroupEditorTypes)[number];
Expand All @@ -16,7 +17,10 @@ export const GroupSchema: IConfigurationSchema = {
properties: {
name: ENTITY_NAME_SCHEMA,
summary: {
type: "string",
...ENTITY_SUMMARY_SCHEMA,
// group snippets (mapped to summary on the entity) have
// a max char limit of 250
maxLength: 250,
},
_thumbnail: ENTITY_IMAGE_SCHEMA,
},
Expand Down
5 changes: 1 addition & 4 deletions packages/common/src/groups/_internal/GroupUiSchemaEdit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ export const uiSchema: IUiSchema = {
options: {
control: "hub-field-input-input",
type: "textarea",
helperText: {
labelKey: "{{i18nScope}}.fields.summary.helperText",
},
},
},
{
Expand All @@ -47,7 +44,7 @@ export const uiSchema: IUiSchema = {
control: "hub-field-input-image-picker",
maxWidth: 727,
maxHeight: 484,
aspectRatio: 1.5,
aspectRatio: 1,
helperText: {
labelKey: "{{i18nScope}}.fields._thumbnail.helperText",
},
Expand Down

0 comments on commit 946aa6f

Please sign in to comment.