Merge pull request #42 from Esri/doc/patch

docs(cdn): update cdn sample to show that deps are external
Esri · Jul 17, 2018 · 87874dd · 87874dd
2 parents 7b60c5d + 3304466
commit 87874dd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/src/guides/from-a-cdn.md b/docs/src/guides/from-a-cdn.md
@@ -24,6 +24,10 @@ group: 1-get-started
   <!-- require polyfills for fetch and Promise from https://polyfill.io -->
   <script src="https://cdn.polyfill.io/v2/polyfill.js?features=es5,Promise,fetch"></script>
 
+  <!-- hub.js has external dependencies on @esri/arcgis-rest-js packages -->
+  <script src="https://unpkg.com/@esri/arcgis-rest-request"></script>
+  <script src="https://unpkg.com/@esri/arcgis-rest-items"></script>
+
   <!-- require @esri/hub.js libraries from https://unpkg.com -->
   <script src="{% cdnUrl data.typedoc | findPackage('@esri/hub-initiatives') %}"></script>
 

diff --git a/docs/src/guides/node.md b/docs/src/guides/node.md
@@ -11,7 +11,7 @@ group: 1-get-started
 Make sure you have polyfills for [`fetch`](https://github.com/matthew-andrews/isomorphic-fetch) and [`FormData`](https://github.com/form-data/isomorphic-form-data) installed before using @esri/hub.js. You can find `npm install` commands for all packages in the [API reference](../../api).
 
 ```bash
-npm install @esri/hub-initiatives isomorphic-fetch isomorphic-form-data
+npm install @esri/hub-initiatives @esri/arcgis-rest-request @esri/arcgis-rest-items isomorphic-fetch isomorphic-form-data
 ```
 
 Require the `isomorphic-fetch` and `isomorphic-form-data` modules before using any of the @esri/hub.js methods.

diff --git a/support/publish.sh b/support/publish.sh
@@ -32,7 +32,7 @@ zip -r $TEMP_FOLDER.zip $TEMP_FOLDER
 rm -rf $TEMP_FOLDER
 
 # Run gh-release to create a new release with our changelog changes and ZIP archive
-gh-release --t v$VERSION --repo hub.js --owner ArcGIS -a $TEMP_FOLDER.zip
+gh-release --t v$VERSION --repo hub.js --owner Esri -a $TEMP_FOLDER.zip
 
 # Delete the ZIP archive
 rm $TEMP_FOLDER.zip