fix: isDiscussable handles undefined subject

affects: @esri/hub-common, @esri/hub-sites ISSUES CLOSED: 10185
Esri · Apr 25, 2024 · 78b3e37 · 78b3e37
1 parent c820942
commit 78b3e37
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/packages/common/src/discussions/utils.ts b/packages/common/src/discussions/utils.ts
@@ -18,7 +18,12 @@ import { IFilter, IHubSearchResult, IPredicate, IQuery } from "../search";
 export function isDiscussable(
   subject: Partial<IGroup | IItem | IHubContent | IHubItemEntity>
 ) {
-  return !(subject.typeKeywords ?? []).includes(CANNOT_DISCUSS);
+  let result = false;
+  if (subject) {
+    const typeKeywords = subject.typeKeywords || [];
+    result = !typeKeywords.includes(CANNOT_DISCUSS);
+  }
+  return result;
 }
 
 /**

diff --git a/packages/common/src/sites/HubSite.ts b/packages/common/src/sites/HubSite.ts
@@ -428,11 +428,7 @@ export class HubSite
     );
 
     const followersGroup = await this.getFollowersGroup();
-    setProp(
-      "_followers.isDiscussable",
-      isDiscussable(followersGroup || {}),
-      editor
-    );
+    setProp("_followers.isDiscussable", isDiscussable(followersGroup), editor);
 
     editor._discussions = this.entity.features["hub:site:feature:discussions"];