fix: failing tests

packages/common/src/utils/poll.ts

@@ -13,12 +13,18 @@ export const poll = async (
     timeBetweenRequests?: number;
   }
 ): Promise<any> => {
-  const { timeout = 30000, timeBetweenRequests = 3000 } = opts || {};
+  const options =
+    opts || /* istanbul ignore next - must pass in overrides for tests */ {};
+  const timeout = options.timeout || 30000;
+  const timeBetweenRequests =
+    options.timeBetweenRequests ||
+    /* istanbul ignore next - cannot delay by this much in tests */ 3000;
+
   let resp: any;
   let requestCount = 0;
 
   do {
-    // on subsequent requests, check if the configured
+    // On subsequent requests, check if the configured
     // timeout has been reached
     // If YES: throw an error
     // If NO: delay before the next request

packages/common/test/utils/poll.test.ts

@@ -2,7 +2,7 @@ import { poll } from "../../src/utils/poll";
 
 describe("poll", () => {
   it("polls the request function until the validation function succeeds", async () => {
-    const validationFn = (resp) => resp && resp.id;
+    const validationFn = (resp: any) => resp && resp.id;
     const requestFnSpy = jasmine
       .createSpy()
       .and.returnValues(Promise.resolve({}), Promise.resolve({ id: "00c" }));
@@ -17,21 +17,19 @@ describe("poll", () => {
     expect(chk.id).toBe("00c");
   });
   it("throws an error when the timeout is reached", async () => {
-    const validationFn = (resp) => resp && resp.id;
+    const validationFn = (resp: any) => resp && resp.id;
     const requestFnSpy = jasmine
       .createSpy()
       .and.returnValue(Promise.resolve({}));
 
-    let errorMessage = "Polling timeout";
     try {
       await poll(requestFnSpy, validationFn, {
         timeBetweenRequests: 100,
         timeout: 200,
       });
     } catch (error) {
-      errorMessage = error.message;
+      expect(requestFnSpy).toHaveBeenCalledTimes(2);
+      expect((error as Error).message).toBe("Polling timeout");
     }
-    expect(requestFnSpy).toHaveBeenCalledTimes(2);
-    expect(errorMessage).toBe("Polling timeout");
   });
 });