refactor(chip)!: Renamed property and updated values #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Renamed `color` property and updated values. - Renamed the property `color`, use `kind` instead. - Updated the accepted values of `kind` to `brand`, `inverse`, and `neutral` (default). - Updated the accepted values of `appearance` to , `outline`, `outline-fill` and `solid` (default).
macandcheese
added
breaking change
github-actions
bot
added
the
refactor
|
Along with the refactored properties and values, these changes incorporate some other small updates to avoid further breaking change in a few months when we add These are being added to Figma - cc @ashetland @SkyeSeitz - there will be visual changes in Chromatic that need approval. Screen.Recording.2022-12-15.at.9.05.37.AM.mov |
driskull
approved these changes
Dec 15, 2022
|
@ashetland @SkyeSeitz I've added you as reviewers here- as @driskull mentioned this has a few extra changes to take a look at - I know these are noted for inclusion for Figma but want to triple check :) |
Yes! These changes are slotted for Figma 🚀 |
SkyeSeitz
approved these changes
Dec 15, 2022
This was referenced Dec 15, 2022
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed
colorproperty and updated values, and updatedappearancevalues.color, usekindinstead.kindtobrand,inverse, andneutral(default).appearanceto ,outline,outline-fillandsolid(default).