Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(alert): simplify setFocus method #10448

Merged
merged 1 commit into from
Oct 1, 2024
Merged

refactor(alert): simplify setFocus method #10448

merged 1 commit into from
Oct 1, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Sep 30, 2024 •
edited
Loading

Related Issue: #6059

Summary

  • remove use of getSlotted utility
  • simplify setFocus method focusing
  • existing tests should suffice

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Sep 30, 2024
@driskull driskull mentioned this pull request Sep 30, 2024
Open
25 tasks
@driskull driskull marked this pull request as ready for review September 30, 2024 22:32
jcfranco
jcfranco approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice cleanup! ✨🧹✨

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 1, 2024
@driskull driskull merged commit 3d56f0e into dev Oct 1, 2024
16 checks passed
@driskull driskull deleted the dris0000/alert-slot-change-fix branch October 1, 2024 16:20
@github-actions github-actions bot added this to the 2.13.1 patch milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

@Elijbet Elijbet Awaiting requested review from Elijbet

Assignees

@driskull driskull

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driskull @jcfranco @geospatialem