feat(popover, action): add component tokens #10253

Elijbet · 2024-09-09T21:05:13Z

Related Issue: #7180

Summary

Add popover component tokens.

--calcite-popover-background-color: Specifies the background color of the component.
--calcite-popover-border-color: Specifies the border color of the component.
--calcite-popover-corner-radius: Specifies the corner radius of the component.
--calcite-popover-text-color: Specifies the text color of the component.

Add action component tokens.

--calcite-action-corner-radius: Specifies the component's corner radius.
--calcite-action-corner-radius-end-end: Specifies the component's corner radius end end.
--calcite-action-corner-radius-end-start: Specifies the component's corner radius end start.
--calcite-action-corner-radius-start-end: Specifies the component's corner radius start end.
--calcite-action-corner-radius-start-start: Specifies the component's corner radius start start.

alisonailea · 2024-09-09T21:12:09Z

This is looking good Eliza! Thanks!

Probably outside this PR but @macandcheese @SkyeSeitz @ashetland @jcfranco per the discussion on accordion-item header, I'm wondering if there is a larger ui pattern we should be setting here allowing component container header backgrounds to be styled separately from the body?

packages/calcite-components/src/components/popover/popover.e2e.ts

packages/calcite-components/src/components/popover/resources.ts

jcfranco · 2024-09-10T17:46:03Z

Probably outside this PR but @macandcheese @SkyeSeitz @ashetland @jcfranco per the discussion on #10181, I'm wondering if there is a larger ui pattern we should be setting here allowing component container header backgrounds to be styled separately from the body?

Outside the scope, but I agree it might be helpful to explore this pattern. I'll defer to the rest of the group on this.

macandcheese · 2024-09-10T17:53:00Z

Probably outside this PR but @macandcheese @SkyeSeitz @ashetland @jcfranco per the discussion on #10181, I'm wondering if there is a larger ui pattern we should be setting here allowing component container header backgrounds to be styled separately from the body?

Outside the scope, but I agree it might be helpful to explore this pattern. I'll defer to the rest of the group on this.

Agreed - many components will require multiple regions of styling - Panel (and consuming components like DIalog) has "content", "header", "footer", "content-top/bottom", etc. that may all be styled separately depending on needs. Same for Block, Accordion, etc.

jcfranco

Looking great, @Elijbet! Just a few more tweaks and this should be good to merge.

packages/calcite-components/src/components/popover/popover.stories.ts

packages/calcite-components/src/components/popover/popover.e2e.ts

packages/calcite-components/src/custom-theme.stories.ts

jcfranco

🚀

macandcheese · 2024-09-12T21:21:59Z

packages/calcite-components/src/components/popover/popover.scss

+ * @prop --calcite-popover-background-color: Specifies the background color of the component.
+ * @prop --calcite-popover-border-color: Specifies the border color of the component.
+ * @prop --calcite-popover-corner-radius: Specifies the corner radius of the component.
+ * @prop --calcite-popover-text-color: Specifies the text color of the component.
 * @prop --calcite-popover-z-index: Sets the z-index value for the component.
 */


I might expect a --calcite-popover-shadow css property here.

I don't see any shadow related styling on the component. Can you expand on that?

It's coming from floating ui - but I don't think a user would need to know that, so maybe a pattern q of how to set that up. As a user I'd want to just set it at the component level like the other adjustments to border color, corner radius, etc.

let's leave the floating-ui tokens separately.

packages/calcite-components/src/components/popover/popover.tsx

packages/calcite-components/src/components/popover/popover.scss

packages/calcite-components/src/components/action/action.scss

jcfranco

✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨
✨🚀🚀🚀🚀✨🚀✨✨✨✨✨🚀✨🚀🚀🚀🚀✨✨🚀🚀🚀✨✨🚀🚀✨✨🚀✨✨✨🚀✨🚀🚀🚀🚀✨🚀✨
✨🚀✨✨🚀✨🚀✨✨✨✨✨🚀✨🚀✨✨✨✨🚀✨✨✨✨🚀✨✨🚀✨🚀🚀✨🚀🚀✨🚀✨✨✨✨🚀✨
✨🚀🚀🚀🚀✨🚀✨✨🚀✨✨🚀✨🚀🚀🚀✨✨✨🚀🚀✨✨🚀✨✨🚀✨🚀✨🚀✨🚀✨🚀🚀🚀✨✨🚀✨
✨🚀✨✨🚀✨🚀✨🚀✨🚀✨🚀✨🚀✨✨✨✨✨✨✨🚀✨🚀✨✨🚀✨🚀✨✨✨🚀✨🚀✨✨✨✨✨✨
✨🚀✨✨🚀✨✨🚀✨✨✨🚀✨✨🚀🚀🚀🚀✨🚀🚀🚀✨✨✨🚀🚀✨✨🚀✨✨✨🚀✨🚀🚀🚀🚀✨🚀✨
✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨✨

jcfranco · 2024-09-23T21:57:51Z

packages/calcite-components/.stylelintrc.cjs

@@ -3,7 +3,10 @@
 // ⚠️ AUTO-GENERATED CODE - DO NOT EDIT
 const customFunctions = [
  "get-trailing-text-input-padding",
-  "scale-duration"
+  "medium-modular-scale",


Per our conversation, I'll look at why these were added since small/medium-modular-scale functions are not defined in dev or in this PR (maybe from node_modules? 🤔).

…tracking * origin/dev: (40 commits) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) fix(list, filter): fix sync between list items and filtered data (#10342) feat(popover): apply component tokens to arrow (#10386) feat(list-item): add `unavailable` property (#10377) fix(segmented-control): honor appearance, layout and scale when items are added after initialization (#10368) fix(action-pad): fix horizontal action group alignment (#10359) fix(combobox): selection-mode="single-persist" correctly selects an item when items have same values (#10366) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) ...

…estone-estimates * origin/dev: (29 commits) fix(input-time-zone): fix region mode labeling and value mapping (#10345) fix(dropdown): open dropdown on `ArrowDown` & `ArrowUp` keys (#10264) refactor(components): reduce post-migration TypeScript errors (#10356) refactor: do not use Host in functional components (#10352) refactor(tests): reduce TypeScript errors (#10344) feat(alert): add component tokens (#10218) fix(card): properly handle slotted elements (#10378) refactor(panel): remove duplicate tailwind class (#10379) feat(popover, action): add component tokens (#10253) chore(t9n): add translations (#10339) feat: add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter (#10373) build: update browserslist db (#10370) ci: resolve husky pre-push and pre-commit errors (#10365) docs: update component READMEs (#10371) feat(text-area): add component tokens (#10343) fix(action): prefer `disabled` in favor of `aria-disabled` (#10367) docs(a11y): add reference to a11y guidance to issue template (#10372) chore(action): add new string for accessible indicator label (#10360) feat(chip): add component tokens (#10179) feat(avatar): add component tokens (#10280) ...

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-ui-icons: 3.32.0</summary> ## [3.32.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-ui-icons@3.31.0...@esri/calcite-ui-icons@3.32.0) (2024-09-30) ### Features * Add 3d building, 3d building parameter, divide, parcel, spaces, spaces parameter, square brackets x, n variable, zoning parameter ([#10373](#10373)) ([3ed86ce](3ed86ce)) * Add content inline right ([#10338](#10338)) ([b4530ab](b4530ab)) * Add dashboard-graph ([#10417](#10417)) ([737085a](737085a)) * Add justify ([#10272](#10272)) ([3d6c013](3d6c013)) * Add model-history, raster-function-history, raster function-template-history, raster-tool-history, tool-history ([#10305](#10305)) ([1e31d43](1e31d43)) * Add parcel parameter ([#10384](#10384)) ([c99be67](c99be67)) * Add trace path and trace path complete ([#10196](#10196)) ([c37ced5](c37ced5)) * Add validate ([#10354](#10354)) ([4160af1](4160af1)) * Add web adaptor ([#10286](#10286)) ([791fd78](791fd78)) * Added connection end left, connection end right, connection middle, connection to connection ([#10198](#10198)) ([3d0f703](3d0f703)) ### Bug Fixes * Correct non-standard filled icon names ([#10309](#10309)) ([7d67334](7d67334)) </details> <details><summary>@esri/eslint-plugin-calcite-components: 1.2.1</summary> ## [1.2.1](https://github.com/Esri/calcite-design-system/compare/@esri/eslint-plugin-calcite-components@1.2.0...@esri/eslint-plugin-calcite-components@1.2.1) (2024-09-30) ### Deprecations * Deprecate `enforce-ref-last-prop` rule ([#10421](#10421)) ([5fde52d](5fde52d)) </details> <details><summary>@esri/calcite-components: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components@2.12.2...@esri/calcite-components@2.13.0) (2024-09-30) ### Features * **accordion-item:** Update component tokens ([ca932b5](ca932b5)) * **action-group, block, panel:** Add `menuPlacement` and `menuFlipPlacements` properties ([#10249](#10249)) ([5ba3112](5ba3112)) * **alert:** Add component tokens ([#10218](#10218)) ([550427b](550427b)) * **alert:** Apply --calcite-alert-corner-radius to internal close button ([#10388](#10388)) ([f50c170](f50c170)) * **avatar:** Add component tokens ([#10280](#10280)) ([f8f881b](f8f881b)) * **carousel:** Improve support for high item counts ([#10315](#10315)) ([6ad2612](6ad2612)) * **checkbox:** Add component tokens ([#10221](#10221)) ([1d87dcf](1d87dcf)) * **chip:** Add component tokens ([#10179](#10179)) ([ff82570](ff82570)) * **dialog, panel:** Add css properties for background-color ([#10387](#10387)) ([d725293](d725293)) * **handle:** Add component tokens ([#10262](#10262)) ([5e73b44](5e73b44)) * **input, input-number, input-text:** Add prefix and suffix width css tokens ([#10206](#10206)) ([7a6ee82](7a6ee82)) * **list-item:** Add `unavailable` property ([#10377](#10377)) ([9332733](9332733)) * **panel:** Improve panel header layout ([#10446](#10446)) ([12f1476](12f1476)) * **popover, action:** Add component tokens ([#10253](#10253)) ([80e8112](80e8112)) * **popover:** Apply component tokens to arrow ([#10386](#10386)) ([2d19268](2d19268)) * **progress:** Add component tokens ([#10267](#10267)) ([8c1259f](8c1259f)) * **text-area:** Add component tokens ([#10343](#10343)) ([d2504b7](d2504b7)) ### Bug Fixes * **action-pad:** Fix horizontal action group alignment ([#10359](#10359)) ([7b03745](7b03745)) * **action-pad:** Update layout on action-group elements slotted after initialization ([#10355](#10355)) ([cf139fa](cf139fa)) * **action:** Prefer `disabled` in favor of `aria-disabled` ([#10367](#10367)) ([1895c07](1895c07)) * **card:** Properly handle slotted elements ([#10378](#10378)) ([99a7148](99a7148)) * **combobox:** Correctly select an item with `selection-mode=‘single-persist’` when items have the same values ([5401ea6](5401ea6)) * **dialog:** Only prevent default on escape key when escapeDisabled is true ([#10336](#10336)) ([0083630](0083630)) * **dropdown:** Open dropdown on `ArrowDown` & `ArrowUp` keys ([#10264](#10264)) ([98548e4](98548e4)) * **input-time-zone:** Fix region mode labeling and value mapping ([#10345](#10345)) ([cf36299](cf36299)) * **input-time-zone:** Fix region mode quirks after update ([#10413](#10413)) ([c137d1f](c137d1f)) * **list, filter:** Fix sync between list items and filtered data ([#10342](#10342)) ([9a66601](9a66601)) * **panel:** Initially closed panel should be hidden ([#10308](#10308)) ([46de96b](46de96b)) * **popover:** Update focus trap elements on mutation observer ([#10357](#10357)) ([725254a](725254a)) * Properly set aria attributes on components ([#10404](#10404)) ([864f3e3](864f3e3)) * Remove aria-disabled from components where necessary ([#10374](#10374)) ([4f8c16c](4f8c16c)) * **segmented-control:** Honor appearance, layout and scale when items are added after initialization ([#10368](#10368)) ([98177f0](98177f0)) * **shell:** Fix z-index of slotted popover elements ([#10325](#10325)) ([7fe1601](7fe1601)) * **text-area:** Ensure border-color token doesn't override invalid styles ([#10390](#10390)) ([699e166](699e166)) * **tooltip:** Closed tooltips should not reappear ([#10420](#10420)) ([a2f3925](a2f3925)) ### Deprecations * **checkbox, radio-button:** Deprecate 'guid' properties ([#10445](#10445)) ([9729ccf](9729ccf)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-ui-icons bumped from 3.32.0-next.5 to 3.32.0 * devDependencies * @esri/eslint-plugin-calcite-components bumped from 1.2.1-next.4 to 1.2.1 </details> <details><summary>@esri/calcite-components-angular: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-angular@2.12.2...@esri/calcite-components-angular@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> <details><summary>@esri/calcite-components-react: 2.13.0</summary> ## [2.13.0](https://github.com/Esri/calcite-design-system/compare/@esri/calcite-components-react@2.12.2...@esri/calcite-components-react@2.13.0) (2024-09-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 2.13.0-next.15 to 2.13.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat(popover): add component tokens

10668af

github-actions bot assigned Elijbet Sep 9, 2024

github-actions bot added the enhancement Issues tied to a new feature or request. label Sep 9, 2024

Elijbet added 3 commits September 9, 2024 15:58

themed e2e test

d0c1d93

import CSS variables from resources

81df053

custom theme

d410806

Elijbet marked this pull request as ready for review September 10, 2024 00:28

Elijbet commented Sep 10, 2024

View reviewed changes

packages/calcite-components/src/components/popover/popover.e2e.ts Outdated Show resolved Hide resolved

Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Sep 10, 2024

Elijbet requested review from alisonailea and jcfranco September 10, 2024 00:40

alisonailea approved these changes Sep 10, 2024

View reviewed changes

packages/calcite-components/src/components/popover/popover.e2e.ts Outdated Show resolved Hide resolved

packages/calcite-components/src/components/popover/resources.ts Outdated Show resolved Hide resolved

import FloatingCSS and clean up resources

69e0cbc

alisonailea mentioned this pull request Sep 11, 2024

Investigate design pattern #10274

Open

Elijbet added 2 commits September 11, 2024 16:14

remove unused style

e70e1b7

remove redundant story

a94882a

jcfranco requested changes Sep 12, 2024

View reviewed changes

Elijbet added 4 commits September 12, 2024 10:52

inline html and cleanup

c43eab3

restore transparentBG_TestOnly story

ea7c73d

remove inline styling and add albel with layout inline instead

ef7ba80

merge dev

7925ef0

jcfranco approved these changes Sep 12, 2024

View reviewed changes

macandcheese reviewed Sep 12, 2024

View reviewed changes

Elijbet added 4 commits September 13, 2024 14:11

add inline label for stories formatting

879d71e

merge dev

f3c7b69

calcite-action rounded corner

38795c5

add action public tokens

0a71e83

Elijbet added 3 commits September 18, 2024 16:03

cleanup

087cbf7

remove internal prop docs

2383c60

rename container

9897306

jcfranco reviewed Sep 19, 2024

View reviewed changes

packages/calcite-components/src/components/popover/popover.tsx Show resolved Hide resolved

geospatialem mentioned this pull request Sep 19, 2024

feat(text-area): add component tokens #10343

Merged

rename container css class

8cc2cd4

jcfranco reviewed Sep 23, 2024

View reviewed changes

packages/calcite-components/src/components/popover/popover.scss Outdated Show resolved Hide resolved

packages/calcite-components/src/components/action/action.scss Outdated Show resolved Hide resolved

Elijbet added 2 commits September 23, 2024 12:59

merge dev

a02d0b4

merge dev

dde6eee

Elijbet requested a review from benelan as a code owner September 23, 2024 20:04

remove internal variables

435d74c

Elijbet changed the title ~~feat(popover): add component tokens~~ feat(popover, action): add component tokens Sep 23, 2024

cleanup

cb068f6

jcfranco approved these changes Sep 23, 2024

View reviewed changes

Elijbet added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Sep 23, 2024

Elijbet merged commit 80e8112 into dev Sep 23, 2024
13 checks passed

Elijbet deleted the elijbet/7180-add-popover-design-tokens branch September 23, 2024 22:28

github-actions bot added this to the 2024-09-30 - 2.13.0 Sep Main release milestone Sep 23, 2024

Elijbet mentioned this pull request Sep 23, 2024

Design token phase II - Integration across components #7180

Open

maxpatiiuk mentioned this pull request Sep 27, 2024

refactor(SASS): update declarations that appear after nested rules #10347

Closed

5 tasks

calcite-admin mentioned this pull request Sep 30, 2024

chore: release main #10457

Merged

benelan mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10461

Closed

calcite-admin mentioned this pull request Oct 1, 2024

chore: release main (#10457) #10463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(popover, action): add component tokens #10253

feat(popover, action): add component tokens #10253

Elijbet commented Sep 9, 2024 •

edited

Loading

alisonailea commented Sep 9, 2024

jcfranco commented Sep 10, 2024

macandcheese commented Sep 10, 2024 •

edited

Loading

jcfranco left a comment

jcfranco left a comment

macandcheese Sep 12, 2024

Elijbet Sep 12, 2024

macandcheese Sep 12, 2024

alisonailea Sep 13, 2024 •

edited

Loading

jcfranco left a comment

jcfranco Sep 23, 2024

feat(popover, action): add component tokens #10253

feat(popover, action): add component tokens #10253

Conversation

Elijbet commented Sep 9, 2024 • edited Loading

Summary

alisonailea commented Sep 9, 2024

jcfranco commented Sep 10, 2024

macandcheese commented Sep 10, 2024 • edited Loading

jcfranco left a comment

Choose a reason for hiding this comment

jcfranco left a comment

Choose a reason for hiding this comment

macandcheese Sep 12, 2024

Choose a reason for hiding this comment

Elijbet Sep 12, 2024

Choose a reason for hiding this comment

macandcheese Sep 12, 2024

Choose a reason for hiding this comment

alisonailea Sep 13, 2024 • edited Loading

Choose a reason for hiding this comment

jcfranco left a comment

Choose a reason for hiding this comment

jcfranco Sep 23, 2024

Choose a reason for hiding this comment

Elijbet commented Sep 9, 2024 •

edited

Loading

macandcheese commented Sep 10, 2024 •

edited

Loading

alisonailea Sep 13, 2024 •

edited

Loading