Treat warnings as errors enabled

Eppie-io · Jun 14, 2024 · 8ea85e0 · 8ea85e0
1 parent 73ea99e
commit 8ea85e0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/Eppie.App/Tuvi.OAuth2/AuthorizationFactory.cs b/src/Eppie.App/Tuvi.OAuth2/AuthorizationFactory.cs
@@ -37,8 +37,8 @@ public static ITokenRefresher GetTokenRefresher(AuthorizationProvider authProvid
 
     public class AuthorizationConfiguration
     {
-        public Func<IAuthenticationBroker> AuthenticationBrokerCreator { get; set; }
-        public Func<GoogleConfiguration> GoogleConfigurationCreator { get; set; }
-        public Func<OutlookConfiguration> OutlookConfigurationCreator { get; set; }
+        public Func<IAuthenticationBroker>? AuthenticationBrokerCreator { get; set; }
+        public Func<GoogleConfiguration>? GoogleConfigurationCreator { get; set; }
+        public Func<OutlookConfiguration>? OutlookConfigurationCreator { get; set; }
     }
 }
diff --git a/src/Eppie.App/Tuvi.OAuth2/AuthorizationProvider.cs b/src/Eppie.App/Tuvi.OAuth2/AuthorizationProvider.cs
@@ -8,7 +8,7 @@ namespace Tuvi.OAuth2
 {
     public class AuthorizationProvider
     {
-        public static AuthorizationProvider Create(HttpClient httpClient, Func<IAuthenticationBroker> brokerCreator, Func<GoogleConfiguration> googleConfigCreator, Func<OutlookConfiguration> outlookConfigCreator)
+        public static AuthorizationProvider Create(HttpClient httpClient, Func<IAuthenticationBroker>? brokerCreator, Func<GoogleConfiguration>? googleConfigCreator, Func<OutlookConfiguration>? outlookConfigCreator)
         {
             return new AuthorizationProvider(httpClient, brokerCreator, googleConfigCreator, outlookConfigCreator);
         }
@@ -20,7 +20,7 @@ public static AuthorizationProvider Create(HttpClient httpClient, Func<IAuthenti
         private readonly Func<GoogleConfiguration> _googleConfigurationCreator;
         private readonly Func<OutlookConfiguration> _outlookConfigurationCreator;
 
-        private AuthorizationProvider(HttpClient httpClient, Func<IAuthenticationBroker> brokerCreator, Func<GoogleConfiguration> googleConfigCreator, Func<OutlookConfiguration> outlookConfigCreator)
+        private AuthorizationProvider(HttpClient httpClient, Func<IAuthenticationBroker>? brokerCreator, Func<GoogleConfiguration>? googleConfigCreator, Func<OutlookConfiguration>? outlookConfigCreator)
         {
             if (httpClient is null)
             {

diff --git a/src/Eppie.App/Tuvi.OAuth2/DefaultEmailConfig.cs b/src/Eppie.App/Tuvi.OAuth2/DefaultEmailConfig.cs
@@ -33,7 +33,7 @@ public static Account CreateDefaultOAuth2Account(MailService mailService)
             return CreateOAuth2Account(mailService, null, null);
         }
 
-        public static Account CreateOAuth2Account(MailService mailService, string email, string refreshToken)
+        public static Account CreateOAuth2Account(MailService mailService, string? email, string? refreshToken)
         {
             var accountData = Account.Default;
 
@@ -70,11 +70,11 @@ public static Account CreateOAuth2Account(MailService mailService, string email,
     internal class DefaultAccountData
     {
         public MailProtocol IncomingMailProtocol { get; set; } = MailProtocol.IMAP;
-        public string IncomingServerAddress { get; set; }
+        public string? IncomingServerAddress { get; set; }
         public int IncomingServerPort { get; set; } = 993;
 
         public MailProtocol OutgoingMailProtocol { get; set; } = MailProtocol.SMTP;
-        public string OutgoingServerAddress { get; set; }
+        public string? OutgoingServerAddress { get; set; }
         public int OutgoingServerPort { get; set; } = 465; // SSL
     }
 }
diff --git a/src/Eppie.App/Tuvi.OAuth2/Tuvi.OAuth2.csproj b/src/Eppie.App/Tuvi.OAuth2/Tuvi.OAuth2.csproj
@@ -6,11 +6,11 @@
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
-    <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>