Update requirements #1335
Merged
Update requirements #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the use of the decorator sklearn.utils.metaestimators.available_if() by TPOT, declare as the minimum version required of scikit-learn the version that introduced this decorator, that was 1.0.
|
The setup.py file should also be updated to match. If you can make that change, I can merge this. |
|
Oh, sorry. Right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the use of the decorator
sklearn.utils.metaestimators.available_if()by TPOT, declare as the minimum version required of scikit-learn the version that introduced this decorator, that was 1.0.What does this PR do?
Update the requirements for TPOT.
Where should the reviewer start?
This is just a value change.
How should this PR be tested?
Verify that TPOT no longer works with scikit-learn version 0.22.0 or any other version prior to 1.0, but it works with version 1.0 and above.
Any background context you want to provide?
I think none is needed.
What are the relevant issues?
There are none, other than TPOT failing to work when all its stated requirements are satisfied.
Screenshots (if appropriate)
None is provided.
Questions:
I think there is one reference that would benefit of attention in the installation section, despite referring to dask.
No, it does not.