Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add improved ts support #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add improved ts support #18

wants to merge 2 commits into from

Conversation

yoav0gal
Copy link

@yoav0gal yoav0gal commented Jan 9, 2024 •
edited
Loading

Used Database from @types/sqlite3 insted of sqlite.
Based of @yukha-dw great work

@Eomm , don't forget to republish to npm when approving!

published to npm for now link

@yukha-dw yukha-dw mentioned this pull request Jan 10, 2024
Closed
@yoav0gal
Copy link
Author

TBH, I don't think I did the types well,
The use sqlite3.open or sqlite.Database based on promiseAPI=true is very confusing.
Created my own version for our needs (powered by sqlite3 only) because my work space is in a hurry.
Fell free to use/migrate fastify-sqlite-typed.

Eomm
Eomm reviewed Jan 20, 2024
View reviewed changes
Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree that the API could be confusing, it was a missing module and I did not get time to shape it correctly.

I will rewrite it bottom-down in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoav0gal @Eomm @yukha-dw