-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EREGCSC-2156 -- Refined policy repository results styling #955
Conversation
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
…s and async calls
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
uses: dkershner6/aws-ssm-getparameters-action@v1 | ||
with: | ||
parameterPairs: "/eregulations/http/test_user = CYPRESS_TEST_USERNAME, | ||
/eregulations/http/test_password = CYPRESS_TEST_PASSWORD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notice that this is using test_user
and test_password
for each environment, which is a newly created user that has no privileges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
✨ See the Django Site in action ✨ |
✨ See the Django Site in action ✨ |
Resolves EREGCSC-2156
Description:
Refines the results styling on the front end for
/policy-repository
documents.Refactors RelatedSections component and related python logic to better route users to the correct section in the reader view.
Adds Cypress end to end tests for authenticated section of
/policy-repository
. Usescypress.env.json
variables locally (which each dev will need to create, since they will not be committed to source control). Uses seededdev
user for experimental deployments. Uses newly createdtest-user
, which has no privileges, fordev
/val
/prod
deployments.This pull request changes:
reader.py
that was not properly getting latest version date and redirecting to correct location for certain URL structures, specifically when linking to a Subpart without a date parameter in the URLlast-updated-date
logic for SPA footerRelatedSections.vue
to not need as many passed-in props to create a URL to the related section. Also simplifies associated utility filter methodlocationUrl
Steps to manually verify this change:
make local
and create the admin instance usingmake local.createadmin
. Create a test usercypress.env.json.template
file to create your owncypress.env.json
config file and fill in the test user and test password valuesmake test.cypress
andmake test.vitest
to make sure all tests pass