EREGCSC-2041 -- Adjust SSA.gov Title 16 links #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
PhilR8
commented
Jul 27, 2023
| @@ -8,7 +8,7 @@ export default { | |||
| eregsComponentLib: r("../regulations/eregs-component-lib"), | |||
| legacy: r("../../regulations"), | |||
| sharedComponents: r( | |||
| "../eregs-component-lib/src/components/shared-components" | |||
| "../regulations/eregs-component-lib/src/components/shared-components" | |||
There was a problem hiding this comment.
update path to match other entries in this file
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
|
✨ See the Django Site in action ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves EREGCSC-2041
Description
Pulls titles from
/v3/actsto be used for the StatuteSelector list items.Fixes issue with Title 16 SSA.gov compilation page URLs.
In the statute table, there is a column for links to the SSA.gov compilation page. Normally, the links to this page only need the title number and the section.
Example: Title 11, Section 1101
✅
https://www.ssa.gov/OP_Home/ssact/title11/1101.htmHowever, SSA.gov Title 16 links are a special case. They need to have a
bappended after the title number.Example: Title 16, Section 1601
❌
https://www.ssa.gov/OP_Home/ssact/title16/1601.htm✅
https://www.ssa.gov/OP_Home/ssact/title16b/1601.htmThis pull request changes:
v3/actsAPI endpoint responsessaGovUrlutility method that checks for the existence of Title 16 and, if found, uses16bas the title in the returned URL.urlMethods.jsStatutes.vueto the sharedutilsfile so those new methods can be used in component unit tests, as well as having unit tests of their own.Steps to manually verify this change:
16binstead of16prodstatute table with title 16 selected