Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eregcsc 2037 update resource use fields #899

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Eregcsc 2037 update resource use fields #899

merged 2 commits into from
Jul 21, 2023

Conversation

peggles2
Copy link
Contributor

@peggles2 peggles2 commented Jul 21, 2023 •
edited
Loading

Resolves #EREGCSC-2037

Description-
Update resource model to use fields.py to reduce redundancy and maintenance of code.

This pull request changes...

  • expected change 2

Steps to manually verify this change...

  1. log into admin panel and ensure resource model is behaving the same.

@peggles2 peggles2 temporarily deployed to dev July 21, 2023 15:26 — with GitHub Actions Inactive
@peggles2 peggles2 temporarily deployed to dev July 21, 2023 15:35 — with GitHub Actions Inactive
@peggles2 peggles2 temporarily deployed to dev July 21, 2023 15:39 — with GitHub Actions Inactive
@peggles2 peggles2 temporarily deployed to dev July 21, 2023 15:39 — with GitHub Actions Inactive
@github-actions
Copy link

✨ See the Django Site in action ✨

@peggles2 peggles2 marked this pull request as ready for review July 21, 2023 16:09
cgodwin1
cgodwin1 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@cgodwin1 cgodwin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peggles2 peggles2 merged commit 8a866d2 into main Jul 21, 2023
16 checks passed
@peggles2 peggles2 temporarily deployed to dev July 21, 2023 20:00 — with GitHub Actions Inactive
@peggles2 peggles2 deleted the EREGCSC-2037-update-resource-use-fields branch July 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgodwin1 cgodwin1 cgodwin1 approved these changes

@thwalker6 thwalker6 Awaiting requested review from thwalker6

@PhilR8 PhilR8 Awaiting requested review from PhilR8 PhilR8 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peggles2 @cgodwin1