Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EREGCSC-2767 Fix grouping post-save hook #1439

Closed
wants to merge 4 commits into from

Conversation

cgodwin1
Copy link
Contributor

@cgodwin1 cgodwin1 commented Oct 7, 2024

Resolves #

Description-

This pull request changes...

  • expected change 1

Steps to manually verify this change...

  1. steps to view and verify change

* on group remove, use related_resources set to compute all affected resources & groups.
  - previously relied only on current groups assigned to the resource, was inaccurate.
* fix group_parent field update behavior
* fix unusual bug where queryset is emptied halfway through the algorithm
* provide more comprehensive unit tests to ensure all behaviors work, including:
  - adding one or more group(s)
  - remove one or more group(s)
  - remove a group and assign a new group in the same save operation
  - ensure group parents are computed properly for all operations
@cgodwin1 cgodwin1 changed the title 2767 fix grouping post save EREGCSC-2767 Fix grouping post-save hook Oct 7, 2024
@cgodwin1 cgodwin1 closed this Oct 7, 2024
@cgodwin1 cgodwin1 reopened this Oct 7, 2024
@cgodwin1 cgodwin1 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant