Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated Error::description #41

Merged
merged 3 commits into from
May 21, 2020

Conversation

robyoung
Copy link
Contributor

Error::description is fully deprecated now.

See: rust-lang/rust#66919

Also a couple of minor tidy ups.

Error::description is fully deprecated now.
See: rust-lang/rust#66919
These functions are only ever used in the tests so best to mark them as
such until they need to be exposed.
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate you taking the time to improve this! Note however that there are plans to move away from quick-error (#36), so a few of these contributions might end up being short-lived.

@Enet4 Enet4 merged commit 77b4712 into Enet4:master May 21, 2020
@robyoung robyoung deleted the remove-deprecated-error-description branch May 29, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants