Add barrier proposal #216
Closed
Add barrier proposal #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! One small thing is that the proposal is under Rendered |
|
@XAMPPRocky whoops, didn't trim enough of the path when I added it 🤦 - will fix! |
XAMPPRocky
reviewed
Nov 10, 2020
This version makes use of closures as suggested, integrates cross-thread data shuffling directly with that concept, and automatically adds control barriers, rather than relying on this to be validated somehow by the compiler.
XAMPPRocky
reviewed
Nov 11, 2020
XAMPPRocky
added
the
s: waiting on review
Closed
Jasper-Bekkers
added a commit
that referenced
this pull request
Feb 26, 2021
It's pretty easy to see why this is unsafe, if multiple threads write to the same coordinate race-conditions happen. Ultimately this should be addressed through something like #216 and some higher level abstractions on top of our buffer types, but since we don't have those for now, marking this as unsafe seems to be the only thing we can do for now.
eddyb
pushed a commit
that referenced
this pull request
Mar 1, 2021
* Safeness bug in StorageImage2d::write It's pretty easy to see why this is unsafe, if multiple threads write to the same coordinate race-conditions happen. Ultimately this should be addressed through something like #216 and some higher level abstractions on top of our buffer types, but since we don't have those for now, marking this as unsafe seems to be the only thing we can do for now. * Remove unsafe {} block for clippy
|
Closing this due to inactivity, if someone would like to start pushing on this again, feel free to reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is designed to primarily address #8, though it also interacts with a few other issues, notably #19 and PR #29.
Lots of discussion on #8 integrated into this proposal, notably including that it uses explicit load/store functions.
Main questions from my perspective are around whether we want to enable a more stable unsafe API first, and what people think of usability of the proposal.