Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist viewer state #186

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Persist viewer state #186

merged 5 commits into from
Feb 9, 2024

Conversation

emilk
Copy link
Collaborator

@emilk emilk commented Feb 2, 2024

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

puffin_viewer will now remember its settings form when you last had it open.

@@ -150,7 +150,7 @@ impl Default for Options {
frame_list_height: 48.0,
frame_width: 10.0,

merge_scopes: true,
merge_scopes: false, // off, because it really only works well for single-threaded profiling
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently unchecking this one each time I start puffin 🤦

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep me too

@emilk emilk merged commit bd4b519 into main Feb 9, 2024
5 of 6 checks passed
@emilk emilk deleted the emilk/store-viewer-state branch February 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants