Switch default compression algorithm to lz4 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2023
lz4_flex is a light-weight Rust-only dependency. It compiles and runs much faster than zstd. zstd compresses better, so you can still opt-in to it with the "zstd" feature. The new puffin streams will be incompatible with old puffin_viewer's puffin_viewer will still be able to open old puffin streams.
1 task
repi
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
lz4_flexis a light-weight Rust-only dependency.It compiles and runs much faster than zstd, and it supports compression in wasm.
zstd compresses better, so you can still opt-in to it with the "zstd" feature.
For most
puffinusers the effect will be faster compilation time and less CPU usage (about a third of zstd). Benchmarks can be found here: #130 (comment)Users of
puffinmust update theirpuffin_viewers, but the newpuffin_viewerwill still be able to open old puffin streams.