fix: add closing tag to "script" tag #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦♂️ Went too fast when creating the release. The last release was a 2.5.0. Will fix that :D |
|
Done 👌 |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a weird issue where in my production app, the JavaScript wasn't working. Spent ages debugging and apparently
<script>elements should always have a closing tag, rather than auto-closing. And applying this change seemed to resolve the issue.I'm not sure if this is just a regression with Firefox developer edition, although it also seemed to fail in Chrome (I'm running on macOS Big Sur), but I'd be interested to know if anyone else experienced this issue.
For reference, I am using HTML 5 DocType (
<!DOCTYPE html>), so self-closing tags should in theory be fine. Although according to MDN, both<script>and</script>should always be included. It looks like this is how it was done in v2.xlaravel-sri/src/Sri.php
Line 96 in bc7d65c